Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add http resp code check for kuberay #435

Merged
merged 1 commit into from
Aug 4, 2022

Conversation

brucez-anyscale
Copy link
Contributor

@brucez-anyscale brucez-anyscale commented Aug 3, 2022

Why are these changes needed?

This pr adds the resp code error handling for RayService.

Related issue number

Checks

  • I've made sure the tests are passing.
  • Testing Strategy
    • Unit tests
    • Manual tests
    • This PR is not tested :(

Copy link
Contributor

@fishbone fishbone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We also need this to be cherry-picked into 0.3.0 @Jeffwan @wilsonwang371

@brucez-anyscale brucez-anyscale merged commit 286a1b8 into master Aug 4, 2022
@Jeffwan
Copy link
Collaborator

Jeffwan commented Aug 5, 2022

@iycheng I will make sure this is cherry-picked to release-0.3 branch

@Jeffwan Jeffwan deleted the brucez/improveHttpClient branch August 5, 2022 00:06
Jeffwan pushed a commit to Jeffwan/kuberay that referenced this pull request Aug 9, 2022
Jeffwan added a commit that referenced this pull request Aug 10, 2022
* Fix nil pointer dereference (#429)

Signed-off-by: Kevin Su <pingsutw@apache.org>

* Fix wrong ray start command (#431)

Signed-off-by: Kevin Su <pingsutw@apache.org>

* Add ray state api doc link in ray service doc (#428)

* Add ray state api doc link in ray service doc

* Update doc

* update

* [doc] Fix config typos

Signed-off-by: Dmitri Gekhtman <dmitri.m.gekhtman@gmail.com>

Fixes a couple of typos in recently introduced sample configs.

* Add http resp code check for kuberay (#435)

* Clean up example samples (#434)

This PR cleans up the "complete" and "autoscaler" sample yamls a bit.
Unnecessary pod spec fields are removed without sacrificing the completeness of the examples.
The idea is to make the configuration look less intimidating.

Signed-off-by: Dmitri Gekhtman <dmitri.m.gekhtman@gmail.com>

* Add more env for RayService head or worker pods (#439)

* fix: worker node can't connect to head node service (#445)

Signed-off-by: Kevin Su <pingsutw@apache.org>

* helm-chart/ray-cluster: allow head autoscaling (#443)

Also allow setting rayVersion

Signed-off-by: Christos Kotsis <28815556+ulfox@users.noreply.github.com>

* Disable async serve handler in Ray Service cluster (#447)

* Add wget timeout to probes (#448)

* Enable tests against release-0.3 branch

Signed-off-by: Kevin Su <pingsutw@apache.org>
Signed-off-by: Dmitri Gekhtman <dmitri.m.gekhtman@gmail.com>
Signed-off-by: Christos Kotsis <28815556+ulfox@users.noreply.github.com>
Co-authored-by: Kevin Su <pingsutw@apache.org>
Co-authored-by: bruce <103957904+brucez-anyscale@users.noreply.github.com>
Co-authored-by: Dmitri Gekhtman <62982571+DmitriGekhtman@users.noreply.github.com>
Co-authored-by: Christos Kotsis <28815556+ulfox@users.noreply.github.com>
Co-authored-by: Yi Cheng <74173148+iycheng@users.noreply.github.com>
Co-authored-by: Wilson Wang <3913185+wilsonwang371@users.noreply.github.com>
lowang-bh pushed a commit to lowang-bh/kuberay that referenced this pull request Sep 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants