fix: worker node can't connect to head node service #445
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kevin Su <pingsutw@apache.org>
Jeffwan
reviewed
Aug 9, 2022
| @@ -43,7 +43,7 @@ func BuildIngressForHeadService(cluster rayiov1alpha1.RayCluster) (*networkingv1 | |||
| PathType: &pathType, | |||
| Backend: networkingv1.IngressBackend{ | |||
| Service: &networkingv1.IngressServiceBackend{ | |||
| Name: utils.GenerateServiceName(cluster.Name), | |||
| Name: utils.CheckName(utils.GenerateServiceName(cluster.Name)), | |||
There was a problem hiding this comment.
Thanks. We internally use short names to overcome such issues but agree that this is indeed a problem worth revisiting.
Jeffwan
approved these changes
Aug 9, 2022
| @@ -47,11 +47,11 @@ func IsRunningAndReady(pod *corev1.Pod) bool { | |||
|
|
|||
| // CheckName makes sure the name does not start with a numeric value and the total length is < 63 char | |||
| func CheckName(s string) string { | |||
| maxLenght := 50 // 63 - (max(8,6) + 5 ) // 6 to 8 char are consumed at the end with "-head-" or -worker- + 5 generated. | |||
Jeffwan
pushed a commit
to Jeffwan/kuberay
that referenced
this pull request
Aug 9, 2022
Signed-off-by: Kevin Su <pingsutw@apache.org>
Jeffwan
added a commit
that referenced
this pull request
Aug 10, 2022
* Fix nil pointer dereference (#429) Signed-off-by: Kevin Su <pingsutw@apache.org> * Fix wrong ray start command (#431) Signed-off-by: Kevin Su <pingsutw@apache.org> * Add ray state api doc link in ray service doc (#428) * Add ray state api doc link in ray service doc * Update doc * update * [doc] Fix config typos Signed-off-by: Dmitri Gekhtman <dmitri.m.gekhtman@gmail.com> Fixes a couple of typos in recently introduced sample configs. * Add http resp code check for kuberay (#435) * Clean up example samples (#434) This PR cleans up the "complete" and "autoscaler" sample yamls a bit. Unnecessary pod spec fields are removed without sacrificing the completeness of the examples. The idea is to make the configuration look less intimidating. Signed-off-by: Dmitri Gekhtman <dmitri.m.gekhtman@gmail.com> * Add more env for RayService head or worker pods (#439) * fix: worker node can't connect to head node service (#445) Signed-off-by: Kevin Su <pingsutw@apache.org> * helm-chart/ray-cluster: allow head autoscaling (#443) Also allow setting rayVersion Signed-off-by: Christos Kotsis <28815556+ulfox@users.noreply.github.com> * Disable async serve handler in Ray Service cluster (#447) * Add wget timeout to probes (#448) * Enable tests against release-0.3 branch Signed-off-by: Kevin Su <pingsutw@apache.org> Signed-off-by: Dmitri Gekhtman <dmitri.m.gekhtman@gmail.com> Signed-off-by: Christos Kotsis <28815556+ulfox@users.noreply.github.com> Co-authored-by: Kevin Su <pingsutw@apache.org> Co-authored-by: bruce <103957904+brucez-anyscale@users.noreply.github.com> Co-authored-by: Dmitri Gekhtman <62982571+DmitriGekhtman@users.noreply.github.com> Co-authored-by: Christos Kotsis <28815556+ulfox@users.noreply.github.com> Co-authored-by: Yi Cheng <74173148+iycheng@users.noreply.github.com> Co-authored-by: Wilson Wang <3913185+wilsonwang371@users.noreply.github.com>
lowang-bh
pushed a commit
to lowang-bh/kuberay
that referenced
this pull request
Sep 24, 2023
Signed-off-by: Kevin Su <pingsutw@apache.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Kevin Su pingsutw@apache.org
Why are these changes needed?
If Ray job name is too long, the worker node will try to connect to the wrong head node service.
The service name is
l94lnxh5ktptbgzsfnj-n0-0-raycluster-xg6hj-head-svc, but worker node try to connect toal94lnxh5ktptbgzsfnj-n0-0-raycluster-xg6hj-head-svc:6379.Related issue number
Checks