[Feature] Set default appProtocol for Ray head service to tcp #668
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @sigmundv |
|
Let's add some notes on the compatibility. This won't be available in earlier kubernetes versions |
Jeffwan
approved these changes
Oct 31, 2022
Thank @Jeffwan for the review! Do you mean updating "Suggested Kubernetes Version" from
|
DmitriGekhtman
approved these changes
Oct 31, 2022
|
@Jeffwan given that this feature was introduced in K8s 1.18, which is before our currently stated lower bound of 1.19, do we need to add additional compatibility info? |
|
We can follow up on compatibility requirements later. |
2 tasks
lowang-bh
pushed a commit
to lowang-bh/kuberay
that referenced
this pull request
Sep 24, 2023
…oject#668) ray-project#625 indicates that the appProtocol field is required to integrate with Open Service Mesh. We discussed how to expose head service for users in the community sync Oct. 25. We did not reach a conclusion in that meeting. Setting the default appProtocol to tcp will not change any existing behaviors because the default value of Protocol is "TCP" (Link). This PR enables users to integrate KubeRay with Open Service Mesh.
2 tasks
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
#625 indicates that the
appProtocolfield is required to integrate with Open Service Mesh. We discussed how to expose head service for users in the community sync Oct. 25. We did not reach a conclusion in that meeting. Setting the defaultappProtocoltotcpwill not change any existing behaviors because the default value ofProtocolis "TCP" (Link). This PR enables users to integrate KubeRay with Open Service Mesh.Some documents related to
appProtocolProtocolspecifies the protocol for all ports, but ports in the same service may have different protocols. Hence,AppProtocolis proposed to specify the protocol for each service port.Why do I use "tcp" rather than "TCP"?
Related issue number
#625
Checks
For manually test, we need to use
kubectl edit $HEAD_SVC. Thekubectl describecommand will not show the information ofappProtocol. The following screenshot shows the values ofappProtocol.