[Bug] Remove an unused field (ingress.enabled) from KubeRay operator chart #812
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DmitriGekhtman
approved these changes
Dec 8, 2022
DmitriGekhtman
pushed a commit
to DmitriGekhtman/kuberay
that referenced
this pull request
Dec 8, 2022
Removes the unused ingress.Enabled field from the operator Helm chart.
This was referenced Dec 8, 2022
DmitriGekhtman
pushed a commit
to DmitriGekhtman/kuberay
that referenced
this pull request
Dec 8, 2022
Removes the unused ingress.Enabled field from the operator Helm chart.
4 tasks
DmitriGekhtman
added a commit
that referenced
this pull request
Dec 8, 2022
lowang-bh
pushed a commit
to lowang-bh/kuberay
that referenced
this pull request
Sep 24, 2023
Removes the unused ingress.Enabled field from the operator Helm chart.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Search ".Values.ingress.enabled" in VS Code. Only one result matches in helm-chart/kuberay-apiserver/templates/ingress.yaml.
kuberay/helm-chart/kuberay-apiserver/templates/ingress.yaml
Line 1 in 781eed1
Related issue number
Checks
All integration tests in KubeRay CI deploy the KubeRay operator via Helm chart.