Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[0.4.0 Pick] Remove ingress.enabled field from operator chart. #813

Conversation

DmitriGekhtman
Copy link
Collaborator

Why are these changes needed?

Picking #812 into the release branch.
FYI @kevin85421 @sihanwang41

Related issue number

Checks

  • I've made sure the tests are passing.
  • Testing Strategy
    • Unit tests
    • Manual tests
    • This PR is not tested :(

Jeffwan and others added 15 commits July 28, 2022 11:45
* Fix nil pointer dereference (ray-project#429)

Signed-off-by: Kevin Su <pingsutw@apache.org>

* Fix wrong ray start command (ray-project#431)

Signed-off-by: Kevin Su <pingsutw@apache.org>

* Add ray state api doc link in ray service doc (ray-project#428)

* Add ray state api doc link in ray service doc

* Update doc

* update

* [doc] Fix config typos

Signed-off-by: Dmitri Gekhtman <dmitri.m.gekhtman@gmail.com>

Fixes a couple of typos in recently introduced sample configs.

* Add http resp code check for kuberay (ray-project#435)

* Clean up example samples (ray-project#434)

This PR cleans up the "complete" and "autoscaler" sample yamls a bit.
Unnecessary pod spec fields are removed without sacrificing the completeness of the examples.
The idea is to make the configuration look less intimidating.

Signed-off-by: Dmitri Gekhtman <dmitri.m.gekhtman@gmail.com>

* Add more env for RayService head or worker pods (ray-project#439)

* fix: worker node can't connect to head node service (ray-project#445)

Signed-off-by: Kevin Su <pingsutw@apache.org>

* helm-chart/ray-cluster: allow head autoscaling (ray-project#443)

Also allow setting rayVersion

Signed-off-by: Christos Kotsis <28815556+ulfox@users.noreply.github.com>

* Disable async serve handler in Ray Service cluster (ray-project#447)

* Add wget timeout to probes (ray-project#448)

* Enable tests against release-0.3 branch

Signed-off-by: Kevin Su <pingsutw@apache.org>
Signed-off-by: Dmitri Gekhtman <dmitri.m.gekhtman@gmail.com>
Signed-off-by: Christos Kotsis <28815556+ulfox@users.noreply.github.com>
Co-authored-by: Kevin Su <pingsutw@apache.org>
Co-authored-by: bruce <103957904+brucez-anyscale@users.noreply.github.com>
Co-authored-by: Dmitri Gekhtman <62982571+DmitriGekhtman@users.noreply.github.com>
Co-authored-by: Christos Kotsis <28815556+ulfox@users.noreply.github.com>
Co-authored-by: Yi Cheng <74173148+iycheng@users.noreply.github.com>
Co-authored-by: Wilson Wang <3913185+wilsonwang371@users.noreply.github.com>
…or (ray-project#457) (ray-project#458)

Co-authored-by: Yi Cheng <74173148+iycheng@users.noreply.github.com>
…ay-project#464) (ray-project#477)

Co-authored-by: Edward Oakes <ed.nmi.oakes@gmail.com>

This picks ray-project#464 into the KubeRay 0.3.0 branch.
That PR changed the names of some config fields to match Ray Serve's API.
* Update helm chart version to 0.3.0 (ray-project#461)

* helm-charts/ray-cluster: Allow extra workers (ray-project#451)

* helm-charts/ray-cluster: Allow extra workers

We can not set additional workers with the current helm chart.
There are some PRs that aim to fix this but they appear to be stale
ray-project#266

We wanted to keep untouched the default worker that is already
included in the helm chart but allow the addition of new workers.

The changes are adding the following logic:
- Allow to disable the default worker group, if needed, via worker.disabled = true
- Allow to set additional workers by using the extraWorkers map

The extraWorkers map has a different structure compared to the default worker because we
wanted to add additional flexibility. Due to that, some variables in the extraWorkers
have different naming (which matches the name of the related CRD attributed)

Note: PR was done to support additional workers in the infrastructure of Metrika.co

* Sync up helm chart's role (ray-project#472)

Co-authored-by: chenyu.jiang <chenyu.jiang@bytedance.com>

* Document the raycluster status (ray-project#473)

Co-authored-by: chenyu.jiang <chenyu.jiang@bytedance.com>

Co-authored-by: Christos Kotsis <ckotsis@metrika.co>
Co-authored-by: Chenyu Jiang <38214590+scarlet25151@users.noreply.github.com>
Co-authored-by: chenyu.jiang <chenyu.jiang@bytedance.com>
* Fix panic in cleanupInvalidVolumeMounts  (ray-project#481)

* fix

* assert

* refine

* Properly convert unix time into meta time (ray-project#480)

* Add timeout to the query parameters

Signed-off-by: Kevin Su <pingsutw@apache.org>

* Properly convert unix time into meta time

Signed-off-by: Kevin Su <pingsutw@apache.org>

Signed-off-by: Kevin Su <pingsutw@apache.org>

Signed-off-by: Kevin Su <pingsutw@apache.org>
Co-authored-by: WanXing Wang <wangwanxing@bytedance.com>
Co-authored-by: Kevin Su <pingsutw@apache.org>
)

* Two more configs updated to 2.0.0

Signed-off-by: Dmitri Gekhtman <dmitri.m.gekhtman@gmail.com>

* autoscaler, job, service

Signed-off-by: Dmitri Gekhtman <dmitri.m.gekhtman@gmail.com>

Signed-off-by: Dmitri Gekhtman <dmitri.m.gekhtman@gmail.com>
Removes the unused ingress.Enabled field from the operator Helm chart.
@DmitriGekhtman
Copy link
Collaborator Author

wrong branch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants