[RayCluster controller] Add headServiceAnnotations field to RayCluster CR

[cskornel-doordash]

Why are these changes needed?

Related issue number

Closes #708

Checks

• I've made sure the tests are passing.
• Testing Strategy
  • Unit tests
  • Manual tests
  • Configuration tests

$ kubectl apply -f ray_v1alpha1_rayservice.yaml
rayservice.ray.io/rayservice-sample created
$ kubectl describe svc rayservice-sample-raycluster-7m5b7-head-svc
Name:              rayservice-sample-raycluster-7m5b7-head-svc
Namespace:         default
Labels:            app.kubernetes.io/created-by=kuberay-operator
                   app.kubernetes.io/name=kuberay
                   ray.io/cluster=rayservice-sample-raycluster-7m5b7
                   ray.io/identifier=rayservice-sample-raycluster-7m5b7-head
                   ray.io/node-type=head
Annotations:       service_key: service_value
...

[kevin85421]

Maybe it is better to have a new field in CRD for users to specify service annotation (e.g. spec.ServiceAnnotations) as mentioned in the #708 issue description.

cc @DmitriGekhtman any thoughts?

[DmitriGekhtman]

Maybe it is better to have a new field in CRD for users to specify service annotation (e.g. spec.ServiceAnnotations) as mentioned in the #708 issue description.

cc @DmitriGekhtman any thoughts?

That would be much better. Please do that instead.

In a future API version, we could move all service configuration into its own field spec.headServiceConfig, or whatever you want to call it.

[cskornel-doordash]

Changed the field to spec.ServiceAnnotations.

[DmitriGekhtman]

This looks pretty good to me.

There's a lint failure due to a funky side-effect make build that changes imports in zz_generated_deepcopy.go.
Revert the change to the imports in that file to fix this.
(Fixing this needs to be tracked.)

[kevin85421]

Thank @cskornel-doordash for your contribution! Overall looks pretty good to me.

[kevin85421]

LGTM! Thank you for your contribution!

[cskornel-doordash]

Thank you for the quick review @kevin85421 @DmitriGekhtman . Would you be able to merge this? I don't have write permissions.