-
Notifications
You must be signed in to change notification settings - Fork 364
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RayCluster controller] Add headServiceAnnotations field to RayCluster CR #841
[RayCluster controller] Add headServiceAnnotations field to RayCluster CR #841
Conversation
Maybe it is better to have a new field in CRD for users to specify service annotation (e.g. cc @DmitriGekhtman any thoughts? |
That would be much better. Please do that instead. In a future API version, we could move all service configuration into its own field |
Changed the field to |
Signed-off-by: Kornel Csernai <69173677+cskornel-doordash@users.noreply.github.com>
This looks pretty good to me. There's a lint failure due to a funky side-effect |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank @cskornel-doordash for your contribution! Overall looks pretty good to me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thank you for your contribution!
Thank you for the quick review @kevin85421 @DmitriGekhtman . Would you be able to merge this? I don't have write permissions. |
…r CR (ray-project#841) Adds headServiceAnnotations field to RayCluster CR. Signed-off-by: Kornel Csernai <69173677+cskornel-doordash@users.noreply.github.com>
Why are these changes needed?
Related issue number
Closes #708
Checks