Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Expose RayCluster service annotations #708

Closed
1 of 2 tasks
DmitriGekhtman opened this issue Nov 10, 2022 · 0 comments · Fixed by #841
Closed
1 of 2 tasks

[Feature] Expose RayCluster service annotations #708

DmitriGekhtman opened this issue Nov 10, 2022 · 0 comments · Fixed by #841
Assignees
Labels
enhancement New feature or request P1 Issue that should be fixed within a few weeks

Comments

@DmitriGekhtman
Copy link
Collaborator

DmitriGekhtman commented Nov 10, 2022

Search before asking

  • I had searched in the issues and found no similar feature requirement.

Description

There are situations in which a user may wish to modify the annotations set on the RayCluster service. So far we've seen this come up for these use-cases

We should probably just add a spec.ServiceAnnotations field to the RayCluster CR.
That's a bit ugly, but it's harmless.

cc @kevin85421

Use case

Described above.

Related issues

There are some related issues, but I wanted to open a more targeted one.

https://discuss.ray.io/t/exposing-kuberay-prometheus-metrics-configuration-on-head-service-annotations/7806/3
#625
#648
#637

Are you willing to submit a PR?

  • Yes I am willing to submit a PR!
@DmitriGekhtman DmitriGekhtman added enhancement New feature or request P1 Issue that should be fixed within a few weeks labels Nov 10, 2022
@kevin85421 kevin85421 self-assigned this Nov 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request P1 Issue that should be fixed within a few weeks
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants