Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[AIR/Tune] ResourceChangingScheduler & AIR API #26130

Closed
Yard1 opened this issue Jun 27, 2022 · 0 comments · Fixed by #26307
Closed

[AIR/Tune] ResourceChangingScheduler & AIR API #26130

Yard1 opened this issue Jun 27, 2022 · 0 comments · Fixed by #26307
Assignees
@Yard1 @xwjiang2010
Labels
bug Something that is supposed to be working; but isn't P2 Important issue, but not time-critical
Milestone
Ray AIR

Comments

@Yard1
Copy link
Member

Yard1 commented Jun 27, 2022 •
edited
Loading

What happened + What you expected to happen

ResourceChangingScheduler is not being tested with the new API and, after a cursory investigation, may not be usable in the first place. We should:

  • Review the AIR APIs to ensure that it is possible to dynamically set resources/scaling config through the scheduler
  • Add tests for ResourceChangingScheduler with AIR API and ensure that the scaling config gets updated accordingly
  • Update ResourceChangingScheduler to work with scaling configs, if needed

Versions / Dependencies

master

Reproduction script

Issue Severity

Medium: It is a significant difficulty but I can work around it.
@Yard1 Yard1 added bug Something that is supposed to be working; but isn't triage Needs triage (eg: priority, bug/not-bug, and owning component) labels Jun 27, 2022
@Yard1 Yard1 added this to the Ray AIR milestone Jun 27, 2022
@xwjiang2010 xwjiang2010 added P1 Issue that should be fixed within a few weeks and removed triage Needs triage (eg: priority, bug/not-bug, and owning component) labels Jun 27, 2022
@ericl ericl added P2 Important issue, but not time-critical and removed P1 Issue that should be fixed within a few weeks labels Jul 5, 2022
@Yard1 Yard1 mentioned this issue Jul 6, 2022
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Yard1 Yard1

@xwjiang2010 xwjiang2010

Labels
bug Something that is supposed to be working; but isn't P2 Important issue, but not time-critical
Projects
None yet
Milestone
Ray AIR
Development

Successfully merging a pull request may close this issue.

[AIR] Fix ResourceChangingScheduler not working with AIR Yard1/ray
3 participants
@ericl @Yard1 @xwjiang2010