Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[air] update actor/task names to work better with ray dashboard #32903

Closed
xwjiang2010 opened this issue Feb 28, 2023 · 6 comments
Closed

[air] update actor/task names to work better with ray dashboard #32903

xwjiang2010 opened this issue Feb 28, 2023 · 6 comments
Assignees
Labels
bug Something that is supposed to be working; but isn't P1 Issue that should be fixed within a few weeks

Comments

@xwjiang2010
Copy link
Contributor

What happened + What you expected to happen

Mainly the following 3 cases:

  • ImplicitFunc
  • _Inner
  • __execute

Versions / Dependencies

master

Reproduction script

NA

Issue Severity

Medium: It is a significant difficulty but I can work around it.

@xwjiang2010 xwjiang2010 added bug Something that is supposed to be working; but isn't triage Needs triage (eg: priority, bug/not-bug, and owning component) P1 Issue that should be fixed within a few weeks and removed triage Needs triage (eg: priority, bug/not-bug, and owning component) labels Feb 28, 2023
@xwjiang2010 xwjiang2010 self-assigned this Feb 28, 2023
@xwjiang2010 xwjiang2010 added this to the Tune Console Output milestone Feb 28, 2023
@xwjiang2010
Copy link
Contributor Author

xwjiang2010 commented Mar 27, 2023

offending script:

from ray import tune
import logging
import time

logger = logging.getLogger(__name__)


def func(config):
    time.sleep(10)
    logger.warn("bla")


tune.run(func)  #  --> scenario #2
# tune.run(tune.with_parameters(func)) --> scenario #1

For both 1 and 2, console output shows

(func pid=5943) bla

However dashboard shows (ImplicitFunc for both 1 and 2):
Screen Shot 2023-03-27 at 11 41 36 AM

We would like both to show up as func (same as in console log).

@xwjiang2010
Copy link
Contributor Author

@rickyyx @rkooo567

@rickyyx rickyyx self-assigned this Mar 27, 2023
@xwjiang2010
Copy link
Contributor Author

Another case that's not quite working:

from ray import tune
from ray.tune import Trainable
import logging
import time

logger = logging.getLogger(__name__)


# def func(config):
#     time.sleep(10) 
#     logger.warn("bla") 

class MyTrainable(Trainable):
    def step(self):
        time.sleep(10)
        logger.warn("foo")

#tune.run(func)
# tune.run(tune.with_parameters(func))
tune.run(tune.with_parameters(MyTrainable))

in console log:

(MyTrainable pid=64249) foo

In dashboard
Screen Shot 2023-03-27 at 12 55 45 PM

@rickyyx
Copy link
Contributor

rickyyx commented Apr 3, 2023

#34012

@rickyyx
Copy link
Contributor

rickyyx commented May 17, 2023

Could this one be close?

@scottsun94
Copy link
Contributor

@krfricke Is this fixed?

@rickyyx rickyyx closed this as completed Jul 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something that is supposed to be working; but isn't P1 Issue that should be fixed within a few weeks
Projects
None yet
Development

No branches or pull requests

3 participants