[Serve] proxy failed to start as starlette removed options attribute from starlette.middleware.Middleware

[ahmed-mahran]

What happened + What you expected to happen

Proxy failed to start with error

File "ray/serve/_private/proxy.py", line 1202, in __init__
self.wrapped_http_proxy, **middleware.options
AttributeError: 'Middleware' object has no attribute 'options'

Starelette has removed this attribute after version 0.34.0
https://github.com/encode/starlette/pull/2381/files#diff-861f6098c0edc67d2e328a0c76c86acf1cd1f4d86fc398a6838d18d69c2bdeaeL7

pip install "starlette<=0.34.0" has fixed it for me. requirements file may be updated accordingly https://github.com/ray-project/ray/blob/master/python/requirements.txt#L56

Versions / Dependencies

Ray version 2.9.0

Reproduction script

Run any serve app

Issue Severity

None

[jingzhaoou]

I just ran into the same error, which burned me an hour. Thanks so much for sharing it!

I resolved the issue by installing Starelette first. Below is my requirements.txt file:

starlette<=0.34.0
ray[serve,data]==2.9.0

[ratnopamc]

Thanks much for sharing, saved a ton of time.

[wpm]

Unfortunately starlette 0.34.0 is incompatible with the latest fastapi.

pip install "ray[serve]"
pip install "starlette<=0.34.0"
...
Installing collected packages: starlette
  Attempting uninstall: starlette
    Found existing installation: starlette 0.35.1
    Uninstalling starlette-0.35.1:
      Successfully uninstalled starlette-0.35.1
ERROR: pip's dependency resolver does not currently take into account all the packages that are installed. This behaviour is the source of the following dependency conflicts.
fastapi 0.109.0 requires starlette<0.36.0,>=0.35.0, but you have starlette 0.34.0 which is incompatible.
Successfully installed starlette-0.34.0

I'm not sure if this affects Ray's functionality. I am able to successfully run the sample client/server application from Running a Ray Serve Application in this configuration.

[chenweisomebody126]

You can degrade your fastapi to a low version such as pip install fastapi==0.104.1 which uses a version of starlette <= 0.34.0

[architkulkarni]

@sihanwang41 is this issue closed now?

[wolvever]

Can ray plan a upgrade. This issue troubles anyone using newer version of FastAPI.

[edoakes]

#42747