Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Core] When using generators, task::execute profile event is not observed on ray timeline #45689

Open
anmyachev opened this issue Jun 3, 2024 · 5 comments
Open

[Core] When using generators, task::execute profile event is not observed on ray timeline #45689

anmyachev opened this issue Jun 3, 2024 · 5 comments
Assignees
@jjyao @rkooo567
Labels
bug Something that is supposed to be working; but isn't core Issues that should be addressed in Ray Core observability Issues related to the Ray Dashboard, Logging, Metrics, Tracing, and/or Profiling P1 Issue that should be fixed within a few weeks size:medium

Comments

@anmyachev
Copy link
Contributor

For example (Ray 2.23.0),

without generators:
image

vs

with generators:
image

I would like to know if this is really a fundamental limitation? I hope that profiling is possible in a way that preserves execution information.
@anmyachev
Copy link
Contributor Author

Hi @stephanie-wang, I see that you had a lot of pull requests about generators, maybe you know the answer to my question or suggestion.

@anmyachev
Copy link
Contributor Author

@devin-petersohn maybe you know who I can ask in Ray about this problem?

@devin-petersohn
Copy link
Member

@edoakes is this expected behavior?

@edoakes
Copy link
Contributor

edoakes commented Jun 17, 2024

@edoakes is this expected behavior?

Hey Devin!! Long time no see :)

Let me ask the right person

@rkooo567
Copy link
Contributor

This was never tested. Theoretically, it should work together, so I guess there's some kind of stupid bug there. @jjyao

@jjyao jjyao added core Issues that should be addressed in Ray Core bug Something that is supposed to be working; but isn't p0.5 labels Jun 18, 2024
@anyscalesam anyscalesam added the observability Issues related to the Ray Dashboard, Logging, Metrics, Tracing, and/or Profiling label Jun 21, 2024
@jjyao jjyao added P1 Issue that should be fixed within a few weeks and removed P0.5 labels Oct 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jjyao jjyao

@rkooo567 rkooo567

Labels
bug Something that is supposed to be working; but isn't core Issues that should be addressed in Ray Core observability Issues related to the Ray Dashboard, Logging, Metrics, Tracing, and/or Profiling P1 Issue that should be fixed within a few weeks size:medium
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@jjyao @edoakes @devin-petersohn @rkooo567 @anmyachev @anyscalesam