Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Rllib] The example code for MADDPG is not being maintained #6803

Closed
jkterry1 opened this issue Jan 16, 2020 · 2 comments
Closed

[Rllib] The example code for MADDPG is not being maintained #6803

jkterry1 opened this issue Jan 16, 2020 · 2 comments
Labels
bug Something that is supposed to be working; but isn't

Comments

@jkterry1
Copy link
Contributor

The example code for how to actually use MADDPG, as listed in the documentation, is here: wsjeon/maddpg-rllib#7

Based on the issues there, the code example couldn't have even been tested before submission, PR key fixes for basic functionality aren't being merged/looked into. I understand that maddpg is still /contrib, but this is a real problem, and needs to be moved to someones library who will merge PRs, etc. I'm happy to fork @wsjeon 's code, fix the instructions, set up an accurate requirements.txt, include the PRs, etc. if you guys would want to change the official pointer to my fork. (I've been doing a ton of work with the MADDPG library recently).

cc @ericl

@jkterry1 jkterry1 added the bug Something that is supposed to be working; but isn't label Jan 16, 2020
@ericl
Copy link
Contributor

ericl commented Jan 16, 2020

Thanks for looking at this @justinkterry . I think we can make a doc update to point to the new maintained repo as an update over the original -- feel free to submit a PR for this once is ready.

@jkterry1
Copy link
Contributor Author

close via PR #6831

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something that is supposed to be working; but isn't
Projects
None yet
Development

No branches or pull requests

2 participants