Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Atomic Data Search extension #589

Merged
merged 8 commits into from
Jan 4, 2022
Merged

Add Atomic Data Search extension #589

merged 8 commits into from
Jan 4, 2022

Conversation

joepio
Copy link
Contributor

@joepio joepio commented Jan 1, 2022

Description

Hi devs of Raycast! Really love your tool. I've built an extension today which I'd like to have published. It's a search plugin for Atomic-Server.

Type of change

  • New extension
Screen.Recording.2022-01-01.at.19.46.49.mov

Screencast

Demo in attachment

Checklist

Copy link
Collaborator

@pernielsentikaer pernielsentikaer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @joepio 👋

Thanks for your contribution 💯

A few suggestions for you to work with before it's ready to get shipped 🚢

Request a new review when you are ready, feel free to contact me here or at Slack if you have any questions.

extensions/atomic/src/index.tsx Outdated Show resolved Hide resolved
extensions/atomic/src/index.tsx Show resolved Hide resolved
extensions/atomic/src/index.tsx Outdated Show resolved Hide resolved
extensions/atomic/package.json Outdated Show resolved Hide resolved
@pernielsentikaer pernielsentikaer self-assigned this Jan 2, 2022
@pernielsentikaer pernielsentikaer added the new extension Label for PRs with new extensions label Jan 2, 2022
joepio and others added 4 commits January 2, 2022 16:16
Co-authored-by: Per Nielsen Tikær <pnt@klean.dk>
Co-authored-by: Per Nielsen Tikær <pnt@klean.dk>
Co-authored-by: Per Nielsen Tikær <pnt@klean.dk>
@joepio
Copy link
Contributor Author

joepio commented Jan 2, 2022

Thanks for the suggestions, @pernielsentikaer !

I've accepted yours and added an icon to the push action.

Copy link
Collaborator

@pernielsentikaer pernielsentikaer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @joepio 👋

Thank you for the update. I'm going to accept it and then will my colleague do a final review before it's finally merged 💎

@joepio
Copy link
Contributor Author

joepio commented Jan 2, 2022

Great, thank you @pernielsentikaer!

Copy link
Member

@mathieudutour mathieudutour left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, this is such an interesting tech

@mathieudutour mathieudutour merged commit 15f1841 into raycast:main Jan 4, 2022
@raycastbot
Copy link
Collaborator

Published to the Raycast Store:
https://raycast.com/joepio/atomic

@joepio
Copy link
Contributor Author

joepio commented Jan 4, 2022

Thanks for the merge, and for the compliment!

I guess I'll need to open a new PR soon, as it currently throws an error :'(.

see #599

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new extension Label for PRs with new extensions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants