[Feature] IsKey... safety checks and more

[nickyMcDonald]

Let me know if there should be tracelogs or asserts or only return false in the safety checks

[actondev]

Some comments. My opinion still stands that the key safety checks should be an assert

[nickyMcDonald]

Some comments. My opinion still stands that the key safety checks should be an assert

I think in order to be consistent with raylib we should just leave it as just a return false;
We could add a TraceLog as @raysan5 pointed out, however that would seem excessive in my opinion.

[ghost]

I really like this. Good job.

Retested successfully on PLATFORM_DESKTOP (Linux Mint 21.1 64-bit) and PLATFORM_WEB (Chromium 115.0.5790.170 64-bit and Firefox 115.1.0esr 64-bit, both running on Linux) with:

#include "raylib.h"

int main(void) {
    InitWindow(800, 450, "test");
    SetTargetFPS(60);
    while (!WindowShouldClose()) {

        int square = 0;
        if (IsKeyPressedRepeat(KEY_ONE)) square = 1;

        BeginDrawing();
        ClearBackground(RAYWHITE);
        if (square == 1) DrawRectangle(20,  20, 50, 50, RED);
        EndDrawing();
    }
    CloseWindow();
    return 0;
}

Edit: I like the return false, but I'm ok either way.

[nickyMcDonald]

Some comments. My opinion still stands that the key safety checks should be an assert

To be clear I'm not against using assert, however I believe it’s best to adhere to the owners standards

[nickyMcDonald]

@ubkp, Thanks!

[raysan5]

@n77y @actondev @ubkp Thank you very much for the improvements and review. Returning false is the behaviour I prefer.

Is issue #2827 being addressed with this PR and previous key-repeat feature addition?

[nickyMcDonald]

@raysan5, No, I believe #2827 is separate. @actondev mentioned it here #3245.

It looks like a separate IsKeyPressed...(int key) would be needed to account for a key pressed and released in a single frame. Interestingly a user could without too much difficulty get around this issue by GetKeyPressed() because when a key is released it does not remove it from the queue. I don’t think that would be ideal though.