Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update demos to support latest changes in Raysect and Matplotlib #420

Closed
vsnever opened this issue Feb 13, 2023 · 1 comment
Closed

Update demos to support latest changes in Raysect and Matplotlib #420

vsnever opened this issue Feb 13, 2023 · 1 comment

Comments

@vsnever
Copy link
Contributor

vsnever commented Feb 13, 2023

A few demos throw errors due to incompatibility with latest versions of Raysect or Matplotlib:

  • optics/logging_trajectories.py The logging ray now logs the Intersection objects instead of Point3D,
  • optics/etendue_of_pinhole.py The arguments nonposx and nonposy of Matplotlib's set_xscale() and set_yscale() methods were replaced with nonpositive a few releases ago,
  • materials/volume.py The Spectrum.samples is now read-only, so updating it with spectrum.samples += ... no longer works and must be replaced with spectrum.samples[:] += ...,
  • materials/modifiers/transform.py Same as for materials/volume.py,
  • materials/volume.py Missing ioff() and show().

I've already fixed these, and will make a PR now.

@vsnever
Copy link
Contributor Author

vsnever commented Feb 13, 2023

Also, materials/tetrahedra_mesh_emission.py fails to run with the latest version of Py3DViewer, but a bug is on their side, cg3hci/py3DViewer#11.

Update: Fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants