-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support meteor.var or .env for secrets #228
Comments
Could we use https://github.com/odpf/meteor/blob/09db3663770352943a17e79235ca6d8f0a1532fd/recipe/envs.go#L12-L14 |
However, template is being used in the recipe reader for applying the parsed template to https://github.com/odpf/meteor/blob/09db3663770352943a17e79235ca6d8f0a1532fd/recipe/reader.go#L54 So, I don't think changing the method signature for |
@burntcarrot Salt does not have a package to serve this need at the moment. Feel free to put a proposal. |
@burntcarrot There are two parts when reading recipe from .yaml to memory (recipe struct):
This proposed feature/enhancement will only focus on part 1 which is collecting data. At this stage it is totally easy to extend. |
Instead of meteor_prefix variable accept a .var or .env for accepting secrets. or maybe support both. If not provided, meteor should also promote users for secrets in the command line before running.
The text was updated successfully, but these errors were encountered: