Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLI & API should Support Deployment of Single/Multiple Namespaces #184

Closed
sravankorumilli opened this issue Feb 25, 2022 · 3 comments · Fixed by #210
Closed

CLI & API should Support Deployment of Single/Multiple Namespaces #184

sravankorumilli opened this issue Feb 25, 2022 · 3 comments · Fixed by #210
Assignees

Comments

@sravankorumilli
Copy link
Contributor

sravankorumilli commented Feb 25, 2022

As per RFC current deploy request accepts only for a single namespace, in a single api call we need to support deployment of single/multiple/all namespaces instead of limiting to single namespace.

Out of Scope

  1. Integrating with the new flow.
@sravankorumilli sravankorumilli changed the title Optimus CLI & API should Support Deployment of Single/Multiple Namespaces CLI & API should Support Deployment of Single/Multiple Namespaces Feb 25, 2022
@deryrahman
Copy link
Member

Some tech debt we encountered during make a changes:

  1. Need namespace convention if we want to deploy multiple namespaces -> cli command can't accept multiple value, unless we split by comma separated
  2. Possibility for jobSpecRepo is nil this loc, but there's no nil checking in command jobCommand, etc that use jobSpecRepo eg this loc
  3. jobCommand should accept namespace as required. We assume we won't able to run optimus create job without specifiying namespace. (job creation can't happen in root)
  4. Proper injecting / loading jobSpecFs / jobRepo in command package. Now, it's scattered

@arinda-arif
Copy link
Contributor

@sravankorumilli @deryrahman @irainia is there a possibility of job deployment without specifying specific namespace? For example empty namespace or [*] namespace means all namespaces in a project.

@irainia
Copy link
Member

irainia commented Mar 2, 2022

@arinda-arif , it's possible mbak. so our plan so far is:

  • get the namespace information:
    • if namespace is is one, then only one
    • if namespace is multiple, then multiple
    • if namespace is not specified, then all

however, the above behaviour only applies for some commands, such as deployment command, but not for others, such as create command. cc: @deryrahman

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants