Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decouple store migration and core domain logic #105

Closed
mabdh opened this issue Jun 15, 2022 · 0 comments · Fixed by #112
Closed

Decouple store migration and core domain logic #105

mabdh opened this issue Jun 15, 2022 · 0 comments · Fixed by #112
Assignees
Labels
enhancement New feature or request

Comments

@mabdh
Copy link
Member

mabdh commented Jun 15, 2022

Is your feature request related to a problem? Please describe.
All domains have a Migrate() function that is being called by migrate command cli only. In this case, mixing migration logic in domain is not needed therefore it is not necessary to add Migrate to the service signature.
On the other hand, there is no business logic when running migration with migrate command. The migration should be store-specific and directly access repository layer.

Describe the solution you'd like

  • Remove MigrateAll() function.
  • Remove Migrate() function in all services.
  • Update migrate command to run repository migration.
@mabdh mabdh added the enhancement New feature or request label Jun 15, 2022
@mabdh mabdh self-assigned this Jun 20, 2022
@mabdh mabdh linked a pull request Jun 21, 2022 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant