Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code coverage has fallen after version upgrade. #965

Closed
SkandaBhat opened this issue Sep 14, 2022 · 3 comments
Closed

Code coverage has fallen after version upgrade. #965

SkandaBhat opened this issue Sep 14, 2022 · 3 comments
Assignees
Labels
Analysis Need for investigation on the description of the issue

Comments

@SkandaBhat
Copy link
Contributor

No description provided.

@SamAg19
Copy link
Member

SamAg19 commented Sep 15, 2022

Coveralls in the master updation commit 09c03e3
443 of 476 branches covered (93.07%) Branch coverage included in aggregate %. 951 of 954 relevant lines covered (99.69%) 386.52 hits per line

Coveralls in code coverage fix commit 07f8cb1 where hardhat and solidity coverage versions were updated
741 of 926 branches covered (80.02%) Branch coverage included in aggregate %. 951 of 954 relevant lines covered (99.69%) 386.52 hits per line

@SamAg19
Copy link
Member

SamAg19 commented Sep 15, 2022

Looks like with solidity coverage 0.8.0+, the way they are counting branches has changed as the number of branches in the code coverage commit has increased compared to previous runs. We will have to go through all contracts once again and see whats not covered.

@SamAg19 SamAg19 added the Analysis Need for investigation on the description of the issue label Sep 15, 2022
@SkandaBhat
Copy link
Contributor Author

@SamAg19 please create a separate issue for this and we can track it separately.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Analysis Need for investigation on the description of the issue
Projects
None yet
Development

No branches or pull requests

2 participants