New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Delegator Contract granted a role which is not required #986

Closed

yohanelly95 opened this issue Feb 17, 2023 · 1 comment

Assignees

Member

yohanelly95 commented Feb 17, 2023 •

edited

Loading

In the postDeployment script, the Delegator contract has granted the GOVERNANCE_ROLE to the governanceAddress. This role does not seem to be required.
The Delegator contract instead needs to grant the admin PAUSE_ROLE which is not done in the current release, to allow the admin to be able to pause the contract. (Pause is imported already but the required role permissions are not given)

Above updates required on the postDeployment script

The text was updated successfully, but these errors were encountered:

yohanelly95 self-assigned this

yohanelly95 mentioned this issue

feat: Delegator V2 that returns Values Struct of Collection #988

Merged

Member Author

yohanelly95 commented Feb 23, 2023

Merged to release-v1.1.2

yohanelly95 closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment