refactor: used the same keystore instance to fetch pKey everytime #1200
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nto yash/raz-794-fetching-private-key-every-time-increases-goroutine-count
ashish10677
requested changes
Apr 11, 2024
ashish10677
approved these changes
Apr 12, 2024
rajkharvar
approved these changes
Apr 23, 2024
Yashk767
added a commit
to Yashk767/razor-go
that referenced
this pull request
Aug 9, 2024
* refactor: used the same keystore instance to fetch pKey everytime (razor-network#1200) * refactor: used regex instead of ks.Accounts to match keystore file * refactor: added more extensive realistic testing for fetching of private key * ci: ignore test-accounts directory in coverage * refactor: added test when multiple timestamps keystore file present for same account * refactor: covered lower and upper case addresses * revert: optimised fetching key from keystore dir * fix: reused same keystore instance for fetching pkey every time * refactor: added realistic tests for fetching of pKey * refactor: removed unused accounts() from interface * refactor: used AccountManager struct with a keystore as a method caller * refactor: fix tests * refactor: removed commented test code * refactor: returned interface instead of type struct instance from AccountManagerForKeystore() * refactor: fixed create tests * refactor: compared expected and returned pKey values in tests * refactor: requested changes * fix: changed keyword to const for defining constants (razor-network#1206) * fix: changed keyword to const for defining constants * fix: fixed lint error by adding explicit type for ProcessRequestRetryDelay * refactor: updated RPC to op sepolia in testing post request * refactor: used a common http client for all the requests (razor-network#1201) * refactor: used a common http client throughout for all the APIs * fix: handled goroutine exit * refactor: golangci-lint fix * refactor: defined http client fields in constants.go * refactor: defined http client as a field to HttpClient struct used as a method caller * refactor: revert InvokeFunctionWithTimeout() changes * refator: fixed tests * refactor: moved httpClient as the first parameter in api.go functions signature * refactor: removed exporting of client field from HttpClient struct * refactor: changed var to const keyword for http client constants * refactor: Optimised number of `GetBlockNumber` and `GetStakerId` eth calls (razor-network#1204) * refactor: Used getStakerId() only once * refactor: used exisiting blockNumber from Vote() in dependent functions * refactor: fixed tests after header being passed as a parameter * fix: removed continous retries if error in fetching block number in logger * refactor: added tests when context is cancelled for Vote() * refactor: fixed vote tests * fix: updated default config values to support both 20 min and shorter 5 min epoch (razor-network#1209) * fix: updated config default max, min values to support longer epoch * fix: updated default config values in config.sh if builded from source * feat: Implemented batching of multiple getStakeSnapshot RPC calls (razor-network#1218) * feat: Implemented batching of multiple getStakeSnapshot RPC calls * refactor: added method caller to batch call functions and added it to interface * refactor: added new and fixed exisiting tests * refactor: fixed log with correct staker Id associated for stake * refactor: moved getStakeSnapshot string to constants * refactor: implemented generic batch call function * refactor: used generic batch call for getStakeSnapshot * refactor: removed timeout and address parameter from GetBiggestStakeAnId() * refactor: fetching jobs and collections from asset caches (razor-network#1207) * feat: added jobs/collections cache structs * feat: added support for using jobs/collections caches * refactor: added time constants required for job/collection cache updates * fix: fixed resetting of cache every expiry interval * refactor: fixed error log * refactor: fix utils tests * refactor: added httpClient instance in commitParams struct * refactor: removed resetting of cache as its not required * feat: checked for job/collection events at the start of commit state in main go routine * refactor: used FilterLogswithRetry and fixed other tests * refactor: fixed benchmark * refactor: moved all the event names to constants * refactor: requested changes * refactor: removed custom http client struct and directly used inbuilt http.Client * refcator: updated default logFileMaxAge and logFileMaxBackups (razor-network#1221) * chore: updated default deployment parameters and version for `v1.2.0` (razor-network#1222) * chore: updated default addresses and chainId to mainnet addresses and chainId * chore: updated testnet addresses to staging europa 20 min epoch * chore: updated version to v1.2.0 * refactor: fixed tests due to state length change to 1200
Yashk767
added a commit
that referenced
this pull request
Aug 9, 2024
* refactor: used the same keystore instance to fetch pKey everytime (#1200) * refactor: used regex instead of ks.Accounts to match keystore file * refactor: added more extensive realistic testing for fetching of private key * ci: ignore test-accounts directory in coverage * refactor: added test when multiple timestamps keystore file present for same account * refactor: covered lower and upper case addresses * revert: optimised fetching key from keystore dir * fix: reused same keystore instance for fetching pkey every time * refactor: added realistic tests for fetching of pKey * refactor: removed unused accounts() from interface * refactor: used AccountManager struct with a keystore as a method caller * refactor: fix tests * refactor: removed commented test code * refactor: returned interface instead of type struct instance from AccountManagerForKeystore() * refactor: fixed create tests * refactor: compared expected and returned pKey values in tests * refactor: requested changes * fix: changed keyword to const for defining constants (#1206) * fix: changed keyword to const for defining constants * fix: fixed lint error by adding explicit type for ProcessRequestRetryDelay * refactor: updated RPC to op sepolia in testing post request * refactor: used a common http client for all the requests (#1201) * refactor: used a common http client throughout for all the APIs * fix: handled goroutine exit * refactor: golangci-lint fix * refactor: defined http client fields in constants.go * refactor: defined http client as a field to HttpClient struct used as a method caller * refactor: revert InvokeFunctionWithTimeout() changes * refator: fixed tests * refactor: moved httpClient as the first parameter in api.go functions signature * refactor: removed exporting of client field from HttpClient struct * refactor: changed var to const keyword for http client constants * refactor: Optimised number of `GetBlockNumber` and `GetStakerId` eth calls (#1204) * refactor: Used getStakerId() only once * refactor: used exisiting blockNumber from Vote() in dependent functions * refactor: fixed tests after header being passed as a parameter * fix: removed continous retries if error in fetching block number in logger * refactor: added tests when context is cancelled for Vote() * refactor: fixed vote tests * fix: updated default config values to support both 20 min and shorter 5 min epoch (#1209) * fix: updated config default max, min values to support longer epoch * fix: updated default config values in config.sh if builded from source * feat: Implemented batching of multiple getStakeSnapshot RPC calls (#1218) * feat: Implemented batching of multiple getStakeSnapshot RPC calls * refactor: added method caller to batch call functions and added it to interface * refactor: added new and fixed exisiting tests * refactor: fixed log with correct staker Id associated for stake * refactor: moved getStakeSnapshot string to constants * refactor: implemented generic batch call function * refactor: used generic batch call for getStakeSnapshot * refactor: removed timeout and address parameter from GetBiggestStakeAnId() * refactor: fetching jobs and collections from asset caches (#1207) * feat: added jobs/collections cache structs * feat: added support for using jobs/collections caches * refactor: added time constants required for job/collection cache updates * fix: fixed resetting of cache every expiry interval * refactor: fixed error log * refactor: fix utils tests * refactor: added httpClient instance in commitParams struct * refactor: removed resetting of cache as its not required * feat: checked for job/collection events at the start of commit state in main go routine * refactor: used FilterLogswithRetry and fixed other tests * refactor: fixed benchmark * refactor: moved all the event names to constants * refactor: requested changes * refactor: removed custom http client struct and directly used inbuilt http.Client * refcator: updated default logFileMaxAge and logFileMaxBackups (#1221) * chore: updated default deployment parameters and version for `v1.2.0` (#1222) * chore: updated default addresses and chainId to mainnet addresses and chainId * chore: updated testnet addresses to staging europa 20 min epoch * chore: updated version to v1.2.0 * refactor: fixed tests due to state length change to 1200 * refactor: removed redundant and incorrect log for staker id (#1226)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Creating a new keystore instance for every transaction costed us an opening of separate goroutine which would start a watcher/updater to check the changes in the keystore directory files. Either creating the instance at the start and using the same instance every time for a transaction would function the same and wouldnt cost up an extra goroutine.
AccountManagerstruct which is used as a method caller toGetPrivateKey()Fixes #1197
How Has This Been Tested?
Ran a staker making transactions in voting process with a goroutine counter placed before and after the getPrivateKey call.