Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: used the same keystore instance to fetch pKey everytime #1200

Merged
merged 17 commits into from
Apr 26, 2024
Merged

refactor: used the same keystore instance to fetch pKey everytime #1200

merged 17 commits into from
Apr 26, 2024

Commits on Mar 20, 2024

  1. refactor: used regex instead of ks.Accounts to match keystore file

    @Yashk767
    Yashk767 committed Mar 20, 2024
    Configuration menu
    Copy the full SHA
    e0cc32a View commit details
    Browse the repository at this point in the history

  2. refactor: added more extensive realistic testing for fetching of priv… 

    …ate key
    @Yashk767
    Yashk767 committed Mar 20, 2024
    Configuration menu
    Copy the full SHA
    7c7e1ff View commit details
    Browse the repository at this point in the history

  3. ci: ignore test-accounts directory in coverage

    @Yashk767
    Yashk767 committed Mar 20, 2024
    Configuration menu
    Copy the full SHA
    1c2692b View commit details
    Browse the repository at this point in the history

  4. refactor: added test when multiple timestamps keystore file present f… 

    …or same account
    @Yashk767
    Yashk767 committed Mar 20, 2024
    Configuration menu
    Copy the full SHA
    9be610b View commit details
    Browse the repository at this point in the history

  5. refactor: covered lower and upper case addresses

    @Yashk767
    Yashk767 committed Mar 20, 2024
    Configuration menu
    Copy the full SHA
    b5eeabc View commit details
    Browse the repository at this point in the history

Commits on Mar 27, 2024

  1. revert: optimised fetching key from keystore dir

    @Yashk767
    Yashk767 committed Mar 27, 2024
    Configuration menu
    Copy the full SHA
    c0ff52c View commit details
    Browse the repository at this point in the history

  2. Merge branch 'develop' of https://github.com/razor-network/razor-go i… 

    …nto yash/raz-794-fetching-private-key-every-time-increases-goroutine-count
    @Yashk767
    Yashk767 committed Mar 27, 2024
    Configuration menu
    Copy the full SHA
    992c141 View commit details
    Browse the repository at this point in the history

  3. fix: reused same keystore instance for fetching pkey every time

    @Yashk767
    Yashk767 committed Mar 27, 2024
    Configuration menu
    Copy the full SHA
    7db8cd2 View commit details
    Browse the repository at this point in the history

  4. refactor: added realistic tests for fetching of pKey

    @Yashk767
    Yashk767 committed Mar 27, 2024
    Configuration menu
    Copy the full SHA
    2a20886 View commit details
    Browse the repository at this point in the history

  5. refactor: removed unused accounts() from interface

    @Yashk767
    Yashk767 committed Mar 27, 2024
    Configuration menu
    Copy the full SHA
    95d4a58 View commit details
    Browse the repository at this point in the history

Commits on Apr 5, 2024

  1. refactor: used AccountManager struct with a keystore as a method caller

    @Yashk767
    Yashk767 committed Apr 5, 2024
    Configuration menu
    Copy the full SHA
    8bd2754 View commit details
    Browse the repository at this point in the history

  2. refactor: fix tests

    @Yashk767
    Yashk767 committed Apr 5, 2024
    Configuration menu
    Copy the full SHA
    36b1c61 View commit details
    Browse the repository at this point in the history

  3. refactor: removed commented test code

    @Yashk767
    Yashk767 committed Apr 5, 2024
    Configuration menu
    Copy the full SHA
    aa262c6 View commit details
    Browse the repository at this point in the history

Commits on Apr 10, 2024

  1. refactor: returned interface instead of type struct instance from Acc… 

    …ountManagerForKeystore()
    @Yashk767
    Yashk767 committed Apr 10, 2024
    Configuration menu
    Copy the full SHA
    1a93d6c View commit details
    Browse the repository at this point in the history

  2. refactor: fixed create tests

    @Yashk767
    Yashk767 committed Apr 10, 2024
    Configuration menu
    Copy the full SHA
    9510190 View commit details
    Browse the repository at this point in the history

Commits on Apr 11, 2024

  1. refactor: compared expected and returned pKey values in tests

    @Yashk767
    Yashk767 committed Apr 11, 2024
    Configuration menu
    Copy the full SHA
    28cb8c2 View commit details
    Browse the repository at this point in the history

  2. refactor: requested changes

    @Yashk767
    Yashk767 committed Apr 11, 2024
    Configuration menu
    Copy the full SHA
    9218d2f View commit details
    Browse the repository at this point in the history