Adds Subscriptions and VA API's Support #12
Conversation
mayankamencherla
commented
Nov 3, 2017
•
mayankamencherla
commented
- Create Plan
- Fetch Plan
- Fetch All plans
- Create subscription
- Fetch subscription
- Fetch all subscriptions
- Cancelling subscription
- Create addon
- Fetch addon
- Delete addon
- Create VA
- Fetch VA
- Edit VA
- Fetch all VAs
- Close VA
- Fetch VA payments
- Fetch payment bank transfer
- Create payment Transfer
- Fetch all payment transfers
- Create direct transfer
- Create transfer reversals
- Fetch transfer
- Edit transfer
|
@sunnyagg Can we just use edit VA for close? In API, we use the same route for both features. |
|
|
||
| public Subscription Cancel() | ||
| { | ||
| string relativeUrl = GetEntityUrl() + "/" + this["id"] + "/cancel"; |
There was a problem hiding this comment.
Need to add constructor for this to create Subscription with given ID ?
src/VirtualAccount.cs
Outdated
|
|
||
| public VirtualAccount Edit(Dictionary<string, object> data) | ||
| { | ||
| string relativeUrl = string.Format("virtual_accounts/{0}", this["id"]); |
| } | ||
|
|
||
| Subscription subscription = TestCreateSubscription(); | ||
|
|
There was a problem hiding this comment.
Create a new subscription with the id of created subscription
test/Helper.cs
Outdated
| return addon2; | ||
| } | ||
|
|
||
| // TODO: Need to re-test this |
src/Addon.cs
Outdated
| { | ||
| string relativeUrl = GetEntityUrl() + "/" + this["id"]; | ||
| List<Entity> entities = Request(relativeUrl, HttpMethod.Delete, null); | ||
| return (Addon)entities[0]; |
There was a problem hiding this comment.
this will throw NullRef.
There was a problem hiding this comment.
public void Delete()
{
string relativeUrl = GetEntityUrl() + "/" + this["id"];
Request(relativeUrl, HttpMethod.Delete, null);
}
test/Helper.cs
Outdated
| // TODO: Need to re-test this | ||
| public static Addon TestDeleteAddon() | ||
| { | ||
| Addon addon = Helper.client.Addon.All()[0]; |
There was a problem hiding this comment.
we should be able to delete from a addon id. need to add a constructor to create addon with given Id
test/Helper.cs
Outdated
| data = JsonConvert.DeserializeObject<Dictionary<string, object>>(json); | ||
| } | ||
|
|
||
| return va.Edit(data); |
There was a problem hiding this comment.
Edit by creating a new VA with id of newly created va
test/Helper.cs
Outdated
| { | ||
| VirtualAccount va = VirtualAccountCreateTest(); | ||
|
|
||
| return va.Close(); |
There was a problem hiding this comment.
same here, close by creating a new va with id of newly created va
test/Helper.cs
Outdated
| { | ||
| VirtualAccount va = VirtualAccountCreateTest(); | ||
|
|
||
| return va.Payments(); |
test/Helper.cs
Outdated
| { | ||
| Subscription subscription = TestCreateSubscription(); | ||
|
|
||
| return subscription.Cancel(); |
There was a problem hiding this comment.
same here, cancel on a object created with the id of existing sub
