Skip to content
This repository has been archived by the owner on Feb 6, 2024. It is now read-only.

Can't disable two factor authentication anymore #31

Closed
calmyournerves opened this issue Nov 7, 2013 · 2 comments
Closed

Can't disable two factor authentication anymore #31

calmyournerves opened this issue Nov 7, 2013 · 2 comments
Labels

Comments

@calmyournerves
Copy link
Contributor

Clicking on the corresponding button when being logged in results in a "Something went wrong"-error.

This is happening because we removed jQuery-ujs together with jQuery and the request is now sent as GET instead of DELETE (or POST with _method=delete). See: https://github.com/rbCAS/CASino/blob/master/app/views/casino/sessions/index.html.erb#L21.

@pencil
Copy link
Member

pencil commented Nov 7, 2013

Should we just re-add jQuery or is someone willing to implement a non-jQuery port of the required jQuery-ujs functionality?

@calmyournerves
Copy link
Contributor Author

Shouldn't be too hard to implement something similar, see https://github.com/rails/jquery-ujs/blob/master/src/rails.js#L160

@pencil pencil closed this as completed in 367482e Nov 9, 2013
pencil added a commit that referenced this issue Nov 9, 2013
Fix for #31: Remove jQuery-ujs dependency
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

2 participants