Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Parser throws on 304s #225

Open
humphd opened this issue Feb 7, 2022 · 0 comments
Open

Parser throws on 304s #225

humphd opened this issue Feb 7, 2022 · 0 comments

Comments

@humphd
Copy link

humphd commented Feb 7, 2022

We're getting errors when a feed is returning 304s, which seems to come from https://github.com/rbren/rss-parser/blob/master/lib/parser.js#L87

I'm wondering if this was actually meant to be >= 400?

If not, why throw on a 304?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@humphd