Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unsafe transforms #35

Closed
brandonkal opened this issue Nov 23, 2018 · 4 comments
Closed

Unsafe transforms #35

brandonkal opened this issue Nov 23, 2018 · 4 comments

Comments

@brandonkal
Copy link

I have noticed this tool makes some unsafe transforms:
Input CSS:

.entry-title {
  line-height: 1.3;
  color: #222;
}

.entry-title a {
  color: #222;
}

.entry-title a:hover {
  color: #666;
}

Output CSS:

.entry-title {
  line-height: 1.3;
  color: #666;
}

.entry-title a {
  color: #222;
}

Here is another simple example:
Input:

small {
  font-size: 80%
}
small {
  font-size: 85%
}

Output:

small {
  font-size: 80%
}
@AndrewEQ
Copy link
Contributor

Thanks for the feedback, will look into it asap.

@AndrewEQ
Copy link
Contributor

AndrewEQ commented Nov 26, 2018

Hey @brandonkal,

I think you may be using an older version, if you're using gulp, make sure your dependencies are up-to-date; I just tested the CSS:

.entry-title {
  line-height: 1.3;
  color: #222;
}

.entry-title a {
  color: #222;
}

.entry-title a:hover {
  color: #666;
}

small {
  font-size: 80%
}
small {
  font-size: 85%
}

and my output was this:

.entry-title {
  line-height: 1.3;
  color: #222;
}

.entry-title a {
  color: #222;
}

.entry-title a:hover {
  color: #666;
}

small {
  font-size: 85%;
}

@brandonkal
Copy link
Author

I should clarify that these rules were several hundred lines apart. I didn't think that mattered but it looks like it does.

@AndrewEQ
Copy link
Contributor

Hmm, ok, could you please send me the non processed CSS to test?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants