Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Response content deserialization improvements #39

Merged
merged 7 commits into from
Apr 7, 2020
Merged

Response content deserialization improvements #39

merged 7 commits into from
Apr 7, 2020

Conversation

rbw
Copy link
Owner

@rbw rbw commented Apr 6, 2020

Fixes a number of issues related response content deserialization:

  • BaseField, allow_none: default to True for all types
  • empty_as_none: Convert empty string to None in deserialization, defaults to True
  • Numeric, Boolean, Email: inherit from marshmallow base for correct types (rather than always string) on load

@rbw rbw mentioned this pull request Apr 6, 2020
Closed
This was linked to issues Apr 6, 2020
Datetime() validation exception if 'resolved_at' value is empty #33
Closed
app.resource.get() raises AttributeError: 'tuple' object has no attribute 'read' #37
Closed
@rbw rbw mentioned this pull request Apr 6, 2020
Closed
@rbw rbw merged commit 26c98ef into master Apr 7, 2020
@rbw rbw deleted the fix-field-deserialization branch April 7, 2020 21:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@rbw