Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bash-preexec #1

Closed
d630 opened this issue Feb 17, 2015 · 4 comments
Closed

bash-preexec #1

d630 opened this issue Feb 17, 2015 · 4 comments

Comments

@d630
Copy link
Contributor

d630 commented Feb 17, 2015

Hey,

I have forked your project and modified it to my needs. Have a look at it, if you like.

Cheers

@rcaloras
Copy link
Owner

Cool man, any particular reason for the fork? I'm interested in trying to address use cases that my current implementation may not support. Not to mention bugs :) Thanks for your interest!

@d630
Copy link
Contributor Author

d630 commented Feb 24, 2015

Ja, there were two reasons:

  • I have removed the sed scripts and (the very smart!) invocation/use of __bp_trim_whitespace() in __bp_precmd_invoke_cmd() to speed up the thing a bit
  • access to $? in the precmd mechanism. Currently, I am using it like this

In my last commit, preexecution is beeing allowed, even though history has been disabled

@rcaloras
Copy link
Owner

Yeah the use of sed to save the previous prompt command and the trimming is all stuff that is a little heavy. I actually just needed to get access to $? as well so I wrote 417c01b to sort of simulate it.

Thanks for your feedback and input. Feel free to open anything or put in a pull request if you want to make changes.

@d630
Copy link
Contributor Author

d630 commented Feb 25, 2015

Thanks!

@d630 d630 closed this as completed Feb 25, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants