Skip to content

Commit

Permalink
Further updates before CRAN release
Browse files Browse the repository at this point in the history
  • Loading branch information
c-brendel committed Apr 5, 2023
1 parent 3b9e5c2 commit 6588622
Show file tree
Hide file tree
Showing 3 changed files with 11 additions and 7 deletions.
2 changes: 1 addition & 1 deletion R/function_CompareFiles.R
Original file line number Diff line number Diff line change
Expand Up @@ -196,7 +196,7 @@ CompareFiles <- function(x, y, type, by = NULL, compare.order = TRUE, threshold
compare[which(same == TRUE), paste0(col, ".y")] <- NA

# If columns are numeric type, then check if values that aren't the same are within specified threshold of eachother
if(class(compare[[paste0(col, ".x")]]) == "numeric" & class(compare[[paste0(col, ".y")]]) == "numeric"){
if(inherits(compare[[paste0(col, ".x")]], "numeric") & inherits(compare[[paste0(col, ".y")]], "numeric")){

# Check if values are within threshold of eachother
close <- abs(compare[paste0(col, ".x")] - compare[paste0(col, ".y")]) <= threshold
Expand Down
14 changes: 9 additions & 5 deletions cran-comments.md
Original file line number Diff line number Diff line change
Expand Up @@ -8,14 +8,18 @@
## R CMD check results
There were no ERRORs or WARNINGs.

There is one NOTE that is only found on Windows (Server 2022, R-devel 64-bit):
There is one NOTE:

```
* checking for detritus in the temp directory ... NOTE
Found the following files/directories:
'lastMiKTeXException'
* checking CRAN incoming feasibility ... [27s] NOTE
Maintainer: 'Rene Capell <hypetools.rene@smhi.se>'
New maintainer:
Rene Capell <hypetools.rene@smhi.se>
Old maintainer(s):
Rene Capell <rene.capell@smhi.se>
```
As noted in [R-hub issue #503](https://github.com/r-hub/rhub/issues/503), this could be due to a bug/crash in MiKTeX and can likely be ignored.
As explained in my email to CRAN, I needed to transfer the R package to a new email address.

## Downstream dependencies
There are currently no downstream dependencies for HYPEtools.
2 changes: 1 addition & 1 deletion release_procedure.R
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ library(dplyr)

# Update DESCRIPTION
# - Package version
# - Package dependencies (cross-check with NAMESPACE)
# - Package dependencies (cross-check with NAMESPACE - note that ggrepel is called in R/functioncollection_internal.R but doesn't show up in NAMESPACE)
# - Read through all sections and check validity

# Update NEWS.md
Expand Down

0 comments on commit 6588622

Please sign in to comment.