Implement separate *NC control highlight groups #176
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the continuation of #174, it fixes the remaining issue I mentioned over there. Now the background should work regardless of which window carries the control UI. I wish Vim's highlight system had a sort of "inheritance" feature that is between
link
and defining from scratch. Then we would not have to do this ugly highlight group patching.For each of the control highlight groups there is now a corresponding highlight group with the same name plus
NC
as suffix. When entering or exiting the window which carries the support groups we reset the 'winbar' option such that the highlight groups are either normal or*NC
.The reason for this is that the user might have a different background for the highlight groups
WinBar
andWinBarNC
. Whenever the user exits or enters a window, the editor will flip between these two groups, so we have to flip our custom highlight groups accordingly as well.