Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug of mix rclex.gen.msgs #236

Merged
merged 1 commit into from
Aug 14, 2023
Merged

Fix bug of mix rclex.gen.msgs #236

merged 1 commit into from
Aug 14, 2023

Conversation

pojiro
Copy link
Contributor

@pojiro pojiro commented Aug 14, 2023

bool 型 msg の C コード生成に不要な中括弧があったのを削除

https://github.com/rt-net/raspimouse2/blob/master/raspimouse_msgs/msg/Leds.msg から生成する際に見つけました

修正により動作することも確認済です

bool 型 msg の C コード生成に不要な中括弧があったのを削除
Copy link
Member

@takasehideki takasehideki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome thanks!!

@takasehideki takasehideki merged commit 60e3d71 into main Aug 14, 2023
7 checks passed
@takasehideki takasehideki deleted the pojiro/patch branch August 14, 2023 01:47
takasehideki added a commit that referenced this pull request Sep 11, 2023
**Full Changelog**: v0.8.5...v0.9.0

* New features:
  * Support Humble (and format with Elixir 1.15.5) by @pojiro in #241
  * Support humble, galactic Nerves by @pojiro in #244
  * change the recommended environment and versions by @takasehideki in #247
  * Add humble support to arm32v7_ros_distros by @pojiro in #248
* Code Improvements/Fixes:
  * Fix bug of `mix rclex.gen.msgs` by @pojiro in #236
  * fix docs about ROS_DISTRO from `foxy` to `humble` by @takasehideki in #249
* Bumps:
  * Bump ex_doc from 0.29.4 to 0.30.6 by @dependabot in #234 #237 #238
  * Bump dialyxir from 1.3.0 to 1.4.1 by @dependabot in #240
  * Bump mix_test_watch from 1.1.0 to 1.1.1 by @dependabot in #242
* Known issues to be addressed in the near future:
  * Lock `git_hooks` to 0.6.5 due to its issue in #138
  * Release rcl nif resources when GerServer terminates in #160
  * `publish/2` sometimes failed just after `create_publisher/3` in #212
  * CI fails randomly at mix test in #246
  * Bump to Iron Irwini in #228
* Note in this release:
  * Please welcome Humble Hawksbill as the new supported distribution for Rclex!! 🎉
@takasehideki takasehideki mentioned this pull request Sep 11, 2023
takasehideki added a commit that referenced this pull request Sep 11, 2023
**Full Changelog**: v0.8.5...v0.9.0

* New features:
  * Support Humble (and format with Elixir 1.15.5) by @pojiro in #241
  * Support humble, galactic Nerves by @pojiro in #244
  * change the recommended environment and versions by @takasehideki in #247
  * Add humble support to arm32v7_ros_distros by @pojiro in #248
* Code Improvements/Fixes:
  * Fix bug of `mix rclex.gen.msgs` by @pojiro in #236
  * fix docs about ROS_DISTRO from `foxy` to `humble` by @takasehideki in #249
* Bumps:
  * Bump ex_doc from 0.29.4 to 0.30.6 by @dependabot in #234 #237 #238
  * Bump dialyxir from 1.3.0 to 1.4.1 by @dependabot in #240
  * Bump mix_test_watch from 1.1.0 to 1.1.1 by @dependabot in #242
* Known issues to be addressed in the near future:
  * Lock `git_hooks` to 0.6.5 due to its issue in #138
  * Release rcl nif resources when GerServer terminates in #160
  * `publish/2` sometimes failed just after `create_publisher/3` in #212
  * CI fails randomly at mix test in #246
  * Bump to Iron Irwini in #228
* Note in this release:
  * Please welcome Humble Hawksbill (and Galactic Geochelone) as the new supported distribution for Rclex!! 🎉
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants