Support Humble (and format with Elixir 1.15.5) #241
Merged
+111
−109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pojiro
changed the title
pojiro
commented
Sep 5, 2023
pojiro
commented
Sep 5, 2023
pojiro
force-pushed
the
support-humble
branch
from
de1d724
to
b9e93f1
Compare
Closed
pojiro
force-pushed
the
support-humble
branch
from
b9e93f1
to
702415a
Compare
Closed
From Humble, C++ headers are installed in a subdirectory https://docs.ros.org/en/rolling/Releases/Release-Humble-Hawksbill.html#c-headers-are-installed-in-a-subdirectory To support it, we add each package's subdirectory by wildcard, https://stackoverflow.com/questions/13897945/wildcard-to-obtain-list-of-all-directories
…:129' rcl_init_options_init/1 must be called before rcl_init_options_fini/1 ref. https://github.com/ros2/rcl/blob/887e69602e694c4a68bbe4aab89f7978cd6effdb/rcl/src/rcl/init_options.c#L129
charlist の mix format の結果が Elixir 1.15 で変更された '' -> ~c"" ことに対応
pojiro
force-pushed
the
support-humble
branch
from
702415a
to
1c4163d
Compare
はやりすぎであったため、 Makefile 内で条件分岐するように修正しました。 |
takasehideki
changed the title
takasehideki
added a commit
that referenced
this pull request
Sep 11, 2023
**Full Changelog**: v0.8.5...v0.9.0 * New features: * Support Humble (and format with Elixir 1.15.5) by @pojiro in #241 * Support humble, galactic Nerves by @pojiro in #244 * change the recommended environment and versions by @takasehideki in #247 * Add humble support to arm32v7_ros_distros by @pojiro in #248 * Code Improvements/Fixes: * Fix bug of `mix rclex.gen.msgs` by @pojiro in #236 * fix docs about ROS_DISTRO from `foxy` to `humble` by @takasehideki in #249 * Bumps: * Bump ex_doc from 0.29.4 to 0.30.6 by @dependabot in #234 #237 #238 * Bump dialyxir from 1.3.0 to 1.4.1 by @dependabot in #240 * Bump mix_test_watch from 1.1.0 to 1.1.1 by @dependabot in #242 * Known issues to be addressed in the near future: * Lock `git_hooks` to 0.6.5 due to its issue in #138 * Release rcl nif resources when GerServer terminates in #160 * `publish/2` sometimes failed just after `create_publisher/3` in #212 * CI fails randomly at mix test in #246 * Bump to Iron Irwini in #228 * Note in this release: * Please welcome Humble Hawksbill as the new supported distribution for Rclex!! 🎉
Merged
takasehideki
added a commit
that referenced
this pull request
Sep 11, 2023
**Full Changelog**: v0.8.5...v0.9.0 * New features: * Support Humble (and format with Elixir 1.15.5) by @pojiro in #241 * Support humble, galactic Nerves by @pojiro in #244 * change the recommended environment and versions by @takasehideki in #247 * Add humble support to arm32v7_ros_distros by @pojiro in #248 * Code Improvements/Fixes: * Fix bug of `mix rclex.gen.msgs` by @pojiro in #236 * fix docs about ROS_DISTRO from `foxy` to `humble` by @takasehideki in #249 * Bumps: * Bump ex_doc from 0.29.4 to 0.30.6 by @dependabot in #234 #237 #238 * Bump dialyxir from 1.3.0 to 1.4.1 by @dependabot in #240 * Bump mix_test_watch from 1.1.0 to 1.1.1 by @dependabot in #242 * Known issues to be addressed in the near future: * Lock `git_hooks` to 0.6.5 due to its issue in #138 * Release rcl nif resources when GerServer terminates in #160 * `publish/2` sometimes failed just after `create_publisher/3` in #212 * CI fails randomly at mix test in #246 * Bump to Iron Irwini in #228 * Note in this release: * Please welcome Humble Hawksbill (and Galactic Geochelone) as the new supported distribution for Rclex!! 🎉
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From Humble, C++ headers are installed in a subdirectory
https://docs.ros.org/en/rolling/Releases/Release-Humble-Hawksbill.html#c-headers-are-installed-in-a-subdirectory
To support it, we add each package's subdirectory by wildcard