Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Composing events fired twice #66

Closed
Anahkiasen opened this issue Oct 19, 2013 · 3 comments
Closed

Composing events fired twice #66

Anahkiasen opened this issue Oct 19, 2013 · 3 comments

Comments

@Anahkiasen
Copy link
Contributor

I had problems with my view composers, I'm using the master branch. When I dump the fired events with a small backtrace, it seems Illuminate/View/Environment fires one, and then later one, TwigBridge fires its own. The problem View passed in the event the core Environment class fires is missing the data bound on View::make while Twig's event has those.

I double checked, I don't have any composer twice somewhere and this happen for all the views. Any idea where it might come from ?

@rcrowe
Copy link
Owner

rcrowe commented Oct 19, 2013

I'll take a look at this.

I had put it in rather quickly to get the feature working for someone that requested it. The library is getting a complete reworking for 0.6.0.

@rcrowe rcrowe mentioned this issue Oct 19, 2013
10 tasks
@barryvdh
Copy link
Collaborator

This is duplicate of #59
I changed this in the loaders branch, because it required some other changes: d44d913
Don't know if there is a better way to detect if the events should be fired (perhaps listening to the events and saving the view already fired?)
In the cases I tested this, it seemed to work.

@rcrowe
Copy link
Owner

rcrowe commented Oct 22, 2013

Closing in favour of #59

@rcrowe rcrowe closed this as completed Oct 22, 2013
@rcrowe rcrowe mentioned this issue Jun 19, 2014
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants