Danpf/msgpack lock to release #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ohh ci! how pretty! |
|
appveyor is broken :( |
|
Hmm ok. Not so nice. @frodofine any hope that you can have a look at what is going on there? It seems like your AppVeyor setup is struggling to checkout the git repo for testing during a pull request? |
Use install command to get submodules instead (see https://www.appveyor.com/docs/how-to/private-git-sub-modules/)
|
Ok seems to work now. @frodofine can you confirm that my changes to the appveyor.yml make sense? |
|
Looks good to me. |
gtauriello
reviewed
Jun 23, 2018
gtauriello
approved these changes
Jun 23, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We should lock to a msgpack release SHA instead of a 'random' SHA.
this locks us to 2.1.5
reference: #7