Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add functionality to read from https and support reduced files. #36

Merged
merged 3 commits into from
Apr 11, 2017
Merged

Add functionality to read from https and support reduced files. #36

merged 3 commits into from
Apr 11, 2017

Conversation

pwrose
Copy link
Collaborator

@pwrose pwrose commented Apr 10, 2017

This resolved issue #34

@coveralls
Copy link

Coverage Status

Coverage increased (+0.3%) to 80.89% when pulling 00c4e0a on pwrose:master into 5cf492f on rcsb:master.

@pwrose
Copy link
Collaborator Author

pwrose commented Apr 11, 2017

This also resolved #33

Copy link
Member

@josemduarte josemduarte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one minor modification, looks great otherwise!

@@ -14,14 +14,55 @@
/** The base url for this version of MMTF. */
public static final String BASE_URL = "http://mmtf.rcsb.org/v1.0/full/";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This constant is not needed anymore, is it?

@coveralls
Copy link

Coverage Status

Coverage increased (+0.4%) to 80.94% when pulling a35a859 on pwrose:master into 5cf492f on rcsb:master.

@pwrose
Copy link
Collaborator Author

pwrose commented Apr 11, 2017

Removed the unused constant.

@josemduarte josemduarte merged commit c04dfcf into rcsb:master Apr 11, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants