Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove duplicate check for whether file is PE, ELF, etc #137

Open
rdbo opened this issue Aug 12, 2023 · 1 comment
Open

Remove duplicate check for whether file is PE, ELF, etc #137

rdbo opened this issue Aug 12, 2023 · 1 comment

Comments

@rdbo
Copy link
Owner

rdbo commented Aug 12, 2023

LIEF already checks if the file is an actual PE/ELF/etc in their Parser::parse functions. No need to check twice.
@rdbo
Copy link
Owner Author

rdbo commented Nov 22, 2023

LIEF can be strange sometimes, maybe I'll leave it there (?)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@rdbo