Add Blink.jl as a dependency to work around Pkg resolver issues. #135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It seems the resolver can't handle our test dependencies. I was looking into the recent Travis failures for this package (https://travis-ci.org/rdeits/MeshCat.jl/jobs/628465886#L323-L338), but also for dependent packages (https://travis-ci.org/JuliaRobotics/MeshCatMechanisms.jl/jobs/629392015#L347-L358). I couldn't really make sense of the unsatisfiable requirements message produced by the resolver, and I eventually found out that simply adding Blink as an explicit dependency of MeshCat makes tests pass again.
|
Opened JuliaGizmos/Blink.jl#226 in response to Travis error on 1.0. |
|
Since this at least fixes the build for OSX and Linux, not only for this package but (hopefully) for all dependencies, I'm going to go ahead and merge this now. |
|
Apologies, the Travis error that I thought was on 1.0 was actually on 1.3, and should be resolved by JuliaGizmos/Blink.jl#225. |
|
👍 thanks for doing this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems the resolver can't handle our test dependencies. I was looking into the recent Travis failures for this package (https://travis-ci.org/rdeits/MeshCat.jl/jobs/628465886#L323-L338),
but also for dependent packages (https://travis-ci.org/JuliaRobotics/MeshCatMechanisms.jl/jobs/629392015#L347-L358). I couldn't really make sense of the unsatisfiable requirements message produced by the resolver, and I eventually found out that simply adding Blink as an explicit dependency of MeshCat makes tests pass again.