Refactored and redid backend #111
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
|
Review away |
|
@ReyhaneAskari can we test travis integration on this PR? |
|
@rdevon yes we should. @joeljpoulin should be working on this. |
|
@joeljpoulin This is apparently because there is no "script" entry in .travis.yml. How to fix? |
|
Why do we have so many CIs? |
ReyhaneAskari
approved these changes
Jun 18, 2018
There was a problem hiding this comment.
It's hard for me to follow what has happened specially because there is no test and there are many changes. I'm OK but you should be rebasing instead of merging when you want to bring the changes of another branch. With rebase you will not have the additional commit that appears in the PR which is basically empty.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR has 0 flake8 errors.
Backend now uses aliases to handle keyword differences in routines and the model.
For example, a routine or build might reference a network "a_net", but this reference is only useful in the context of the routine or build. The model owns a dictionary of all the networks, and the routine simply has an alias (can be thought of a sort of pointer) to that network. That way, the routine can reference "a_net" without knowing how the model is using it.
Updated classifier, gan, vae, and ali to follow this framework.
Cleaned up code and fixed some small errors.
Cleaned up noise.py
Removed global network handler.
Now, routines and builds "own" their kwargs and help. These are containers of aliases which point to the model kwargs and help.
All models "train" correctly, but no tests are implemented. This is the next step.
cortex-config does not work (this script is not yet compatible with cortex.)
Note / TODO:
The interface for building models works, but it can be tricky to debug. This needs to be stressed tested as well as include more informative errors.