-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Nuance "plain objects (JSON) cannot be used." #104
Comments
This seems relevant to https://github.com/rdfjs/representation-task-force/issues/79 (forwarding DataFactory). One could pass factory that creates objects without methods? |
That would be a spec-incompatible factory, but yes, could be so for simplicity. |
This issue in rdflib.js by @fletcher91 seems relevant: linkeddata/rdflib.js#219 (Functional-style datamodel & performance) |
While we are at it, I'd suggest removing I understand that what is meant by "JSON objects" is something like objects created using the literal syntax or |
If we want to ship at least the Data interfaces spec, do we still need to address something in this issue?
@RubenVerborgh I think currently you might have the best understanding of rdflib issues, I see that issue mentioned above resulted in PR which claims: linkeddata/rdflib.js#272 (comment)
|
Relevant: #137 |
I've scanned this, but I don't think they are relevant. |
To clear up any possible confusion, the changes in linkeddata/rdflib.js#272 don't implement the issue brought up in linkeddata/rdflib.js#219 Rather than rewriting rdflib.js to a functional model, it merely ensures any Term has at most and only one instance. So calling a factory with the same argument multiple times always returns the same instance, as does calling the constructor with the same argument ( On a second note, consider the following;
Both |
Maybe we just remove:
as it sounds like the spec forbids any usage of JSON in the context of the RDFJS Data Model and
cause we don't have a standard way to do it and based on the experience using the current Data Factory, I don't see the requirement. Of course any library can implement it. |
I see that https://github.com/rdfjs/data-model/ also optimizes memory use by storing all the redundant values (like |
As @vhf mentioned, let's try to avoid using the term "JSON" here since that is a string interchange format and what we are talking about here (perhaps for lack of a better phrase) are 'plain objects'. In fact, in graphy, such plain objects are allowed in certain places since they are technically superclasses of |
Nothing in the spec necessitates methods. (Or namespaces, for that matter.) “Equality” and “conversion” are cited. The spec never mentions conversion. As for equality: function equals(one, other) {
if (one && other && one.termType === other.termType) {
switch (one.termType) {
case "DefaultGraph":
return true;
case "NamedNode":
case "BlankNode":
case "Variable":
return one.value === other.value;
case "Literal":
return (
one.value === other.value &&
one.language === other.language &&
equals(one.datatype, other.datatype)
);
default:
return (
equals(one.subject, other.subject) &&
equals(one.predicate, other.predicate) &&
equals(one.object, other.object) &&
equals(one.graph, other.graph)
);
}
}
return false;
} Those are the equality semantics of the spec. Forever. RDF is twenty years old and it's not getting any new primitives (so no “expression problem”). With that, a consumer can process values: import { equals } from "some-rdf-api-implementation"
const select = (triples, subject) =>
triples.filter(_ => equals(_.subject, subject)); More importantly, a producer can construct valid resources with no runtime dependencies: const jaws_of_victory = () => ({
subject: { termType: 'NamedNode', value: 'http://rdf.js.org/' },
predicate: { termType: 'NamedNode', value: 'http://snatches.org' }
object: 'http://defeat.org',
graph: { termType: 'DefaultGraph', value: "" }
}; Helper functions are trivial to write, and they do not need to be conformant. Conformant factory functions can confer implementation-specific benefits (e.g. @fletcher91 can optimize space by memoizing or interning)—but any piece of data can be processed. If you don't trust incoming values, you can normalize them (akin to #137), but you don't have to. That is the “minimal necessary interface.” Mandating the use of methods amounts to specifying an implementation. As things stand, producers effectively MUST import or implement the spec, just so that the equality methods can be schlepped around with every single value, as required. Why? The original RDF API spec, which failed, also took this “OOP” approach, perhaps because that's what is codified by the industrial-strength “WebIDL” meta-spec that it follows. The stated goal of WebIDL is merely to support interop on the web, and nowhere does it motivate the exclusive use of classes as top-level constructs. Clearly, though, it targets the standardization of built-ins such as XMLDOM, SVG, and other vendor-provided API's that will live in the global namespace. As such, it never mentions modules, which are the province of specs like this one, which will be fulfilled (or not) by userland implementations that can export whatever they want. Flexibility is lost, and nothing is gained by the use of methods and namespaces. Their use is not motivated by the spec, and the design notes, which consider alternate approaches, appear inconclusive. The wish to support “plain objects” is not just about deserialization (as asserted in #143). Consumers of protocols need facilities, but many producers don't. The fact that you can reconstitute a conformant value on the other end of a socket just illustrates that the method wasn't carrying anything essential and is only needed by the receiver. The same is true for interop within runtimes. Yes, JSON-LD was designed as a transport format. But the insistence on support for passive conformance by data producers (what Sporny called “zero edits”) has been critical to its success, and it is a general design principle. Please forgive my lack of “nuance.” I am a semantic web convert and I want RDF to succeed. I am just giving my perspective as an observer. |
The RDF/JS representation task force is about finding a common way to deal with the RDF model with a JavaScript-idiomatic API. The RDF API spec was not JavaScript-idiomatic. Floating methods are not JavaScript-idiomatic. JSON-LD is a JavaScript-idiomatic data format. The objects we propose in the current RDF/JS spec are a JavaScript-idiomatic API. This is the core of everything. I welcome any objections to that point, but I have not seen any. |
With regards to the more functional approach (be it
Isn't the ability to use equality operators,
I feel there is an argument for emphasising 'common' over 'javascript-idiomatic', since excluding a sizeable part of the JS community and functional languages which compile to JS might put a wedge in-between the already niche JS-based RDF community. Extracting the method interfaces for both |
There surely is, but that was never the goal of RDF/JS (note the 'JS' 😉). All we want is an API that looks like all other JavaScript APIs. |
In #142 (comment) I suggested not to 'bless' any specific @bergos suggested on chat that we try to gather all the arguments in one place so that we can make well informed decision all together: https://gitter.im/rdfjs/Representation-Task-Force?at=5c4ee99ef04ef006449c86b5 |
@RubenVerborgh Well, "common" within the scope of JS of course, but it seems we can have our cake and eat it too. The plain object definition would be a strict subset of either FP and OOP extensions. So it'd seem arbitrary to limit a low-level spec to exclude projects/people, especially since JS' main building block is |
Defining equality is core to interoperability, so that would be a -1 from me.
But who's asking to restrict ourselves to such a subset? Which project or use case tangibly benefits from such a subset? |
Look, the original issue here about plain objects has been resolved in #147, so as the creator of this issue, I will close it. By no means do I want to stop the discussion that @fletcher91 and @elf-pavlik want to have, but that is really a different issue. So if you want to continue, by all means, but please start a new issue specifically about |
I've done so myself: #150 |
The statement
if confusing; we probably want something more correct.
The text was updated successfully, but these errors were encountered: