Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

catch version 2.13.4 building with glibc v2.35 causes a compiler error? #1

Closed
Thomashrb opened this issue Nov 23, 2022 · 2 comments · Fixed by #2
Closed

catch version 2.13.4 building with glibc v2.35 causes a compiler error? #1

Thomashrb opened this issue Nov 23, 2022 · 2 comments · Fixed by #2

Comments

@Thomashrb
Copy link
Contributor

I followed the instructions from the readme but the make step produced an error for me.

I found a github issue containing the same error message I saw:
catchorg/Catch2#2421

bumping Catch2 by one minor version fixed the issue for me:

@@ -29,7 +29,7 @@ set(CPM_DOWNLOAD_LOCATION "cmake/CPM.cmake")
 include(${CPM_DOWNLOAD_LOCATION})
 
 # Specify dependencies
-CPMAddPackage("gh:catchorg/Catch2@2.13.4")
+CPMAddPackage("gh:catchorg/Catch2@2.13.5")
 
 # Including packages for safe_numerics
 CPMAddPackage(NAME safe_numerics

also thank you for making this :)

@Thomashrb Thomashrb changed the title catch versions 2.13.4 building with glibc v2.35 causes a compiler error catch version 2.13.4 building with glibc v2.35 causes a compiler error? Nov 23, 2022
@rdjondo
Copy link
Owner

rdjondo commented Nov 23, 2022

Hello, @Thomashrb, feel free to contribute to the repo with your fix by opening a Pull Request and I will merge it. Thank you🙏

@Thomashrb
Copy link
Contributor Author

^ ok I opened a pr. I am new to PRs on github (and cpp) so if I did something wrong please let me know and I will be happy to fix my mistake.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants