bug: CollectionWrapper remove method doesn't work

[ricardo-a-alves-alb]

Hello,

We were trying to use the remove() method available on the CollectionWrapper and it doesn't seem to work.

Lightning-ui/src/helpers/CollectionWrapper.js

Lines 132 to 143 in 1d9801d

	remove(item) {
	if(this.hasItems && item.assignedID) {
	for(let i = 0; i < this.wrapper.children.length; i++) {
	if(this.wrapper.children[i].assignedID === item.assignedID) {
	return this.removeAt(i);
	}
	}
	}
	else {
	throw new Error('remove: item not found');
	}
	}

From our investigation, the culprit seems to be the that this.wrapper.children doesn't contain the property assignedID.
Using the internal get items() seems to fix the issue, because it returns the component if it is alive.

Lightning-ui/src/helpers/CollectionWrapper.js

Lines 526 to 534 in 1d9801d

	get items() {
	const itemWrappers = this.itemWrappers;
	return this._items.map((item, index) => {
	if(itemWrappers[index] && itemWrappers[index].component.isAlive) {
	return itemWrappers[index].component;
	}
	return item;
	});
	}

If replacing the blocks that use this.wrapper.children with this.items seems good to you, I can provide a PR to be merged.

[jfboeve]

Thanks for bringing this to my attention. This is fixed in version 1.3.3