getDeclaringClass() not safe to use

[Danack]

When you call Injector->execute on a function, and it requires a non-typehinted param which has not been defined, the error message is generated with the code:

$declaringClass = $param->getDeclaringClass()->getName();
            throw new InjectionException(
                sprintf($this->errorMessages[self::E_UNDEFINED_PARAM], $declaringClass,$param->name),
                self::E_UNDEFINED_PARAM
            );

This can be replicated with the code:

$provider = new \Auryn\Provider();
$provider->execute('functionMissingParamDefine');

exit(0);

$param->getDeclaringClass() does not always work as you would expect. If execute is called from within another class it returns that classes name. e.g. if you put the above code in a test case inside ProviderTest, it returns ProviderTest.

I encountered this by as it returns null when the execute is called from outside a class.

I will fix this when I've re-merged my code with Levi's ninja reorganisation.

[Danack]

This is fixed in Danack/Auryn@8ada817 which is post PR-64.

Just to note once again, the test needs to be run outside of a class - which is why there is now a test in the bootstrap. If anyone has a better way of organising this, I am all ears.

[Danack]

Hmm - it still gives the wrong information when a closure is missing a param define and it is called within a class.

$provider->prepare('\StdClass', function($obj, \Auryn\AurynInjector $injector) {
            $obj->testval = 42;
        });
        $obj = $provider->make('StdClass');

gives No definition available while attempting to provision typeless non-concrete parameter ProviderTest(obj)

[Danack]

This was fixed during the big merge.