NFT-1310: fix address checksum + introduce findSingleDeploymentOrThrow #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bauti-defi
changed the title
size-limit report 📦
|
cawfree
reviewed
Apr 18, 2023
cawfree
reviewed
Apr 18, 2023
bauti-defi
commented
Apr 18, 2023
cawfree
reviewed
Apr 18, 2023
cawfree
reviewed
Apr 18, 2023
cawfree
approved these changes
Apr 19, 2023
There was a problem hiding this comment.
Merged with issues: https://linear.app/renft/issue/NFT-1310#comment-b40086be
cawfree
deleted the
bauti/nft-1310-add-findsingledeploymentorthrow-and-fix
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes included:
findSingleDeploymentOrThrow()method has been introducedisValidDeployment()method has been introduced. -> Uses zod schema to verify deployments are valid.Testing:
Replaced all
@renft/sdkpackage.json dependencies with this version locally.stopLendtransaction on Avalanche with reNFT dev wallet (https://snowtrace.io/tx/0xd3578d7a92d72cdfef1adf4500e74412eac2cd1690316b04b2940caabe598c3f)lendtransaction on polygon with reNFT dev wallet (https://polygonscan.com/tx/0x8162b7b6707489fab159baf6144edcdd9e4dd9af6f801feb8bf1abc5f82ed3fe)stopLendtransaction on polygon with reNFT dev wallet (https://polygonscan.com/tx/0xf34d4fa1a87c1ba803ce03d1b59c0a961cf80d12bb2d11293aa48cccf82e951d)yarn e2e testpassingyarn testpassing.