Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tidying Up Examples #24

Merged
merged 8 commits into from
May 4, 2023
Merged

Tidying Up Examples #24

merged 8 commits into from
May 4, 2023

Conversation

nazariyv
Copy link
Member

@nazariyv nazariyv commented May 3, 2023

No description provided.

@nazariyv nazariyv marked this pull request as draft May 3, 2023 21:26
@github-actions
Copy link

github-actions bot commented May 3, 2023 •
edited
Loading

size-limit report 📦

Path Size
dist/sdk.cjs.production.min.js 127.55 KB (0%)
dist/sdk.esm.js 46.23 KB (0%)

@nazariyv
Copy link
Member Author

nazariyv commented May 3, 2023

changed to draft because we need to sort out two things here:

  • when getting a contract supplying a Wallet type gives me not a Signer error, which makes little sense because Wallet extends Signer
  • I have my doubts about whether the README.md example we give people even actually works...

@nazariyv
Copy link
Member Author

nazariyv commented May 3, 2023

changed to draft because we need to sort out two things here:

  • when getting a contract supplying a Wallet type gives me not a Signer error, which makes little sense because Wallet extends Signer
  • I have my doubts about whether the README.md example we give people even actually works...

addressed both of these now

@nazariyv nazariyv marked this pull request as ready for review May 3, 2023 22:19
bauti-defi
bauti-defi reviewed May 4, 2023
View reviewed changes
examples/package.json
"@ethersproject/providers": ">=5.5.0",
"@ethersproject/wallet": ">=5.5.0",
"@ethersproject/abstract-signer": ">=5.5.0",
"@renft/sdk": "6.0.0-alpha.9"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we wanna use newest alpha.10 version here?

@nazariyv nazariyv merged commit e2ab2b3 into main May 4, 2023
@bauti-defi bauti-defi deleted the naz/examples-tidy-up branch May 15, 2023 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bauti-defi bauti-defi bauti-defi left review comments

@cawfree cawfree Awaiting requested review from cawfree

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nazariyv @bauti-defi