-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add missing input binding method getType #26
Conversation
7297fe9
to
0fb80be
Compare
…. Fixes shiny::registerInputHandler with reactR inputs.
0fb80be
to
1eba39e
Compare
getType
getType
@alandipert makes sense. I will likely wait a couple of weeks to avoid upsetting our friends at CRAN. |
@alandipert just got to play with this and my
Will package authors need to change their code to work with this change? Or will the scaffold need to be changed? I believe we are missing a |
Hm, I didn't expect them to. I probably misunderstood what |
@alandipert I mistakenly thought that As of now, I think we should revert this commit, but it does seem we need to find a way for a user to provide a |
@alandipert these Shiny lines confirm that a handler is required if |
The reactR-generated Shiny input binding was missing an implementation for
getType
, which is required in order forshiny::registerInputHandler
to work.This PR adds an implementation that simply identifies the input by the unique name we're already collecting from the user.