Bfix/reorder imports #1275

mihir0x69 · 2016-11-27T09:50:43Z

This is for #1229. Work's still in process.

coveralls · 2016-11-27T11:02:50Z

Coverage remained the same at 98.605% when pulling f9b9776 on KarandikarMihir:bfix/reorder-imports into b796a3a on mxstbr:dev.

mihir0x69 · 2016-11-27T11:27:12Z

@gihrig There's one problem that I can't wrap my head around why import/first rule doesn't accept imports like components/A or containers/App. I think this is a known issue (I'll refer to it once I find it).

UPDATE
If you set import/first to 2, you'd still find around 28 errors. All of them are related to absolute path errors. How can containers/App be called as absolute path?

coveralls · 2016-11-27T12:19:50Z

Coverage remained the same at 98.605% when pulling d30c171 on KarandikarMihir:bfix/reorder-imports into b796a3a on mxstbr:dev.

coveralls · 2016-11-27T12:35:40Z

Coverage remained the same at 98.605% when pulling 28f4ca2 on KarandikarMihir:bfix/reorder-imports into b796a3a on mxstbr:dev.

coveralls · 2016-11-27T12:44:29Z

Coverage remained the same at 98.605% when pulling 0c0aa77 on KarandikarMihir:bfix/reorder-imports into b796a3a on mxstbr:dev.

gihrig · 2016-11-28T09:13:07Z

@KarandikarMihir I cloned your repo then added #1261 and I have no errors! 😄

Check this out for yourself, but I think with #1261 merged you're PR is good to go.

Let us know If this works out for you. If so, I'll try to squeeze out some time to test more thoroughly.

mihir0x69 · 2016-11-28T09:44:55Z

@gihrig Awesome! Thanks for checking. Did you try setting import/first to 2? I merged #1261 with this and it's still giving me errors. 😕

Also, templates/app.js differs from app/app.js. Is that on purpose, or is template/app.js out of sync?

UPDATE
The latest commit has zero errors with import/first set to 0. Thanks to #1261. ✨

coveralls · 2016-11-28T10:18:38Z

Coverage remained the same at 98.578% when pulling 9807dda on KarandikarMihir:bfix/reorder-imports into 62c1aa2 on mxstbr:dev.

coveralls · 2016-11-28T11:14:31Z

Coverage remained the same at 98.578% when pulling e169e20 on KarandikarMihir:bfix/reorder-imports into b152688 on mxstbr:dev.

coveralls · 2016-12-01T09:13:07Z

Coverage remained the same at 98.578% when pulling b5c6e50 on KarandikarMihir:bfix/reorder-imports into 8cbeea1 on mxstbr:dev.

Dattaya · 2016-12-02T18:58:56Z

So now we can get rid of this rule "import/first": 0 altogether, because by default it is enabled in airbnb eslint config, right?

gihrig · 2016-12-02T20:22:45Z

@Dattaya Yes, I put it in there to work around the errors @KarandikarMihir has fixed, it should be removed when this lands ✨

Edit: mentioned @Dattaya as author, was @KarandikarMihir Oops 😊

coveralls · 2016-12-03T01:47:01Z

Coverage remained the same at 98.578% when pulling d41a212 on KarandikarMihir:bfix/reorder-imports into 03b9af6 on mxstbr:dev.

gihrig · 2016-12-03T01:52:52Z

@KarandikarMihir

The latest commit has zero errors with import/first set to 0.

How about with import/first removed?

…o dev

mihir0x69 · 2016-12-03T05:13:10Z

@gihrig No joy. It's giving me errors after removing import/first.

gihrig · 2016-12-03T06:43:30Z

@KarandikarMihir Do these new errors "make sense" in term of the order of imports you have been working on? In other words are they just more of the same or some weird new breed? 😉

coveralls · 2016-12-08T14:45:41Z

Coverage remained the same at 98.578% when pulling c1ed993 on KarandikarMihir:bfix/reorder-imports into 7efa929 on mxstbr:dev.

coveralls · 2016-12-08T14:45:41Z

Coverage remained the same at 98.578% when pulling c1ed993 on KarandikarMihir:bfix/reorder-imports into 7efa929 on mxstbr:dev.

mihir0x69 · 2016-12-08T14:46:06Z

@gihrig Done and dusted!

gihrig · 2016-12-09T00:05:48Z

Fantastic 🎉

99.99% there!

I have tested thoroughly and found only two issues in this monumental work.

Everything is good, until I generate a container. There are some issues in the generated code.

To reproduce:

npm run generate component TestComp /w defaults
npm run generate container TestPage /w defaults
npm run generate route TestPage - /test
use TestComp on TestPage
(patch generated test files just to make them pass)
npm test

And then there are merge conflicts... I'd like to call your attention to this #1205 comment. Since this has been merged, dev is currently in a broken state, so beware of that.

I really appreciate your hanging in there with this, I imagine it turned out to be a bigger task than you expected from the start 😉

coveralls · 2016-12-09T06:00:43Z

Coverage remained the same at 98.585% when pulling 5ccd9e5 on KarandikarMihir:bfix/reorder-imports into 72663f0 on mxstbr:dev.

mihir0x69 · 2016-12-09T06:04:21Z

@gihrig Thanks for the heads-up! That was tedious 😅 generateing containers and components won't have any import/first errors. It does throw one lint error.

/home/xxxx/react-boilerplate/app/containers/TestPage/sagas.js
  5:3  error  Unnecessary return statement  no-useless-return

I believe it's out of scope of this PR.

I really appreciate your hanging in there with this, I imagine it turned out to be a bigger task than you expected from the start 😉

IKR

gihrig · 2016-12-09T06:48:24Z

I believe it's out of scope of this PR.

Yes, that issue is addressed in #1231

I'm having to end for the "day", I'll get back to testing this in about 9 hrs.

Looking forward to merging!

Dattaya

I just have one request, hopefully you can see it in templates/app.js

Dattaya · 2016-12-07T19:29:48Z

internals/templates/app.js

@@ -88,6 +94,7 @@ if (!window.Intl) {
  }))
    .then(() => Promise.all([
      System.import('intl/locale-data/jsonp/en.js'),
+      System.import('intl/locale-data/jsonp/de.js'),


When you run npm run clean, all of the languages are whipped out except English, so this line shouldn't be in this template.

Very good catch!

coveralls · 2016-12-09T08:48:50Z

Coverage remained the same at 98.585% when pulling ffe3dd0 on KarandikarMihir:bfix/reorder-imports into 72663f0 on mxstbr:dev.

mxstbr

LGTM, let's merge this for 3.4!

gihrig · 2016-12-09T16:47:20Z

Fantastic job! 🎉

I have generated all options and there are no lint errors ✨
(excluding unrelated #1231 errors)

You sir, have made a great contribution to code quality, not just in RBP, but from here on everyone will receive the benefit of import/first. My code quality is eternally grateful 💯

Merging.

mxstbr · 2016-12-09T20:24:14Z

Yes, thanks so so much @KarandikarMihir!

Bring import order in line with react-boilerplate#1275

mihir0x69 · 2016-12-11T07:24:19Z

@gihrig @mxstbr Thank you for sailing through thick and thin! 🙌 😇

* Add ProgressBar, modify App and write tests * fix eslint warnings * Prevent memory leak in App/index, Fix animation of ProgressBar, Add more tests * Add more tests for ProgressBar life cycle methods * Rename css class names, remove eslint-disable, add comments * Remove comments from ProgressBar tests * Prevent re-rendering of ProgressBar * Fix failing test * Add one more condition to complete progress * Update index.test.js Bring import order in line with #1275 * Update App/index.js * Update App/index.js * Fix re-rendering and make tests pass * Move progress route hooks out of <App />, update tests * Reset progress bar speed * Move <ProgressBar /> out of <App /> * Update tests * Move withProgressBar to components/ProgressBar * Rename withProgressBar -> index.js. * Add docs for ProgressBar working/usage * Update progress bar.md

- Take the next step and bring the default containers to Pure Functions. - Also, align import formatting separation with the work done in react-boilerplate#1275.

@lamoglia

* feat(docs): Extracting packages into their own modules (react-boilerplate#979) * fix(internals): Fix babel relative preset Fix webpack issue with relative babel preset paths: babel/babel-loader#149 * feat(docs): Add docs for extracting components Add draft version of docs describing how to extract components to their own npm packages. * feat(core): Move to Jest for testing (react-boilerplate#980) * Add Jest collect coverage * fix(tests): set config and globals add coverage and script update coveralls script update chai to jest syntax args should return an array chore(tests): add babel-jest, tweak config chore(tests): update coverage settings feat(cov): remove untested closure chore(core): update watch script, use jest-cli fix(watch): add no-cache and watchAll flags * Remove generator test * jest-cli@16 * chore(jest): Remove rootDir * rebase against 3.3.0 * fix(commands): Fix 'npm run clean' breaking (react-boilerplate#1185) (react-boilerplate#1186) Added a constants.js file to templates that contains the DEFAULT_LOCALE export to be added to containers/App/constants on 'npm run clean'. * fix(example): Fix i18n button not updating (react-boilerplate#1187) * feat(docs): Faq: staying updated with boilerplate (react-boilerplate#1192) * fix(example): Fix console error on lang change (react-boilerplate#1200) * fix(core): npm run generate language is not properly created. (react-boilerplate#1199) * rerun extract-intl * add default language to language provider * feat(webpack): new query object syntax (react-boilerplate#1198) * feat(ci): Node v7 support (react-boilerplate#1197) * Node version support update * Update CI node versions * fix(docs): Replace start:prod with independent start:production (react-boilerplate#1204) * fix(example): Fix default Intl polyfill language (react-boilerplate#1208) * fix(docs): Fix typo in file name (react-boilerplate#1211) * fix(example): Use `createStructuredSelector` instead of `createSelector` (react-boilerplate#1212) * chore(deps): update deps roll-up Nov-12-2016 (react-boilerplate#1225) * chore(deps): update deps roll-up Nov-19-2016 (react-boilerplate#1252) * Prevent language duplication (react-boilerplate#1253) * Satisfy ESLint rule: no-restricted-syntax (react-boilerplate#1243) * feat(webpack) Add circular dependency plugin for Webpack. (react-boilerplate#1262) * feat(webpack) Add circular dependency plugin for Webpack. This plugin detects circular dependencies and shows a warning or fails. It is less obtrusive to just show a warning. That's why it defaults to that. * small fix to webpack config * Remove webpack DedupePlugin (react-boilerplate#1218) * Fix typo in container generator (react-boilerplate#1242) * fix(eslint config): resolve numerous invalid lint errors seen in Atom editor (react-boilerplate#1261) * Disable ESLint rule: no-confusing-arrow (react-boilerplate#1238) * Fix links to styled-components doc (react-boilerplate#1289) * Add missing document (Using Sass section CSS) to table content (react-boilerplate#1271) * fix react-boilerplate#1270 * add brackets to document Using Sass * Remove '#if wantCSS' from generator templates (react-boilerplate#1260) Remove '#if wantCSS' from container generator Remove '#if wantCSS' from es6 pure generator template * feat(core): Don't import all of lodash * fix(package.json): Required npm version (react-boilerplate#1219) * Fix wrong npm version introduced with d202b07 Commit d202b07 introduced a not existing npm version of >= 5 which does not exist. The correct npm version is checked during installation which might otherwise lead to an error. Conclusion might be that this was meant to be node >= 5 like mentioned in react-boilerplate#1197 * Add the supported version of node * chore(deps): update deps roll-up Dec-03-2016 (react-boilerplate#1301) * chore(deps): update deps roll-up Dec-03-2016 * fix(deps): sagas loaded twice - roll back react-router-redux 4.0.7 -> 4.0.6 * chore(test config): expand Jest moduleNameMapper key to include common file types (react-boilerplate#1293) * chore(selectors): refactor selectors (react-boilerplate#1205) * Improve .editorconfig, change insert_final_newline to true, add trim_trailing_whitespace (react-boilerplate#1239) * fix(scripts): make LocaleToggle's massages compatible with `extract-intl` script (react-boilerplate#1251) Fixes react-boilerplate#1221 Reverts back react-boilerplate#813 * feat(example): Extracted ReposList (react-boilerplate#1285) * Bfix/reorder imports (react-boilerplate#1275) * Reorder imports * Track package.json * Reorder remaining imports * Revert few changes in app/app.js * Add .ico extension to file-loader regex * Revert favicon, manifest, .htaccess imports * Revert favicon, manifest, .htaccess imports * Remove ico from image-webpack loader extensions * Move offline-plugin import to the top in templates/app.js * Match templates/app.js with app/app.js * Remove import/first from package.json * Reorder webpack alias imports * Reorder imports in internals/generators * Remove German from templates/app.js * fix(templates): use correct name of a selector (react-boilerplate#1321) * chore(generators): clean up generator templates (react-boilerplate#1304) Follow up to react-boilerplate#1260 * fix(generator): react-boilerplate#1231 'generate container' produces unnecessary return (react-boilerplate#1327) * chore(internal): fix indentation in 'routeWithReducer' (react-boilerplate#1329) * fix(HomePage): react-boilerplate#1232 Saga effects should be yielded (react-boilerplate#1328) * fix(generator): 'generate container' produces unnecessary return - better solution (react-boilerplate#1333) * fix(generator): react-boilerplate#1231 'generate container' produces unnecessary return * fix(generator): improved solution to 'generate container' produces unnecessary return react-boilerplate#1327 * feat(ci): allow for linting of the templates (react-boilerplate#1223) * feat(ci): allow for linting of the templates * Add comment at the top describing the purpose of generate-templates-for-linting.js * Use __dirname instead of process.cwd() * Update yarn.lock * Test coverage updates (react-boilerplate#1334) * Exclude test files from test coverage * Add coverage threshold * Update css readme (react-boilerplate#1338) * fix(generators, templates): add example app functionality into project templates and generators (react-boilerplate#1331) * fix(generators, templates): add existing example app functionality into project templates and generators * fix(generators, templates): add existing example app functionality into project templates and generators * split messages import to avoid disabling an eslint rule * feat(server): Add host command line parameter to start (react-boilerplate#1249) * add host parameter to logger * add host parameter to server * update docs to include host command line parameter * update host port command doc based on suggesitons * Rollback image-webpack-loader (react-boilerplate#1342) * Remove babel-jest expicit dependency (react-boilerplate#1345) implements react-boilerplate#1344 * Make compatible with other babel plugins (react-boilerplate#1355) * Remove psi and pagespeed (react-boilerplate#1352) * removing psi, pagespeed, and doc references * remove psi from yarn.lock * Trigger full page reload when hmr fails (react-boilerplate#1357) Fixes react-boilerplate#1353 * refactor(server): remove console.log causing server screen clutter (react-boilerplate#1361) * feat(example): Add route loading progress bar (react-boilerplate#1008) * Add ProgressBar, modify App and write tests * fix eslint warnings * Prevent memory leak in App/index, Fix animation of ProgressBar, Add more tests * Add more tests for ProgressBar life cycle methods * Rename css class names, remove eslint-disable, add comments * Remove comments from ProgressBar tests * Prevent re-rendering of ProgressBar * Fix failing test * Add one more condition to complete progress * Update index.test.js Bring import order in line with react-boilerplate#1275 * Update App/index.js * Update App/index.js * Fix re-rendering and make tests pass * Move progress route hooks out of <App />, update tests * Reset progress bar speed * Move <ProgressBar /> out of <App /> * Update tests * Move withProgressBar to components/ProgressBar * Rename withProgressBar -> index.js. * Add docs for ProgressBar working/usage * Update progress bar.md * Split ProgressBar/styles.js into two separate files * chore(package.json): update dependecy The test/build failed due to a regressed dependency. "react-addons-test-utils": "15.3.2", -> "react-addons-test-utils": "15.4.1", * feat(docs) a beginner's guide to RBP (react-boilerplate#1366) * Create introduction.md * Update introduction.md Minor edits for grammar and structure. Overall, really really good. The hours of dedicated effort you put in will be appreciated by many to come! Very well done 😄 * Update introduction.md Here I have implemented the changes mentioned by @web2style and @lamoglia Thanks guys! :spakles: * Host workflow.png internally * Reference local image in markdown * Rename Workflow.png -> workflow.png * Move to Jest Documentation (react-boilerplate#1390) * Move to Jest Documentation - Move from Mocha to Jest documentation - Remove rewire docs and replace with Jest snapshot information * Minor edits Overall very good, only a few minor edits for style. * Remove jest-cli cmd * Update commands.md * Update deployment.md * fix(core): ngrok not working (react-boilerplate#1399) Node's http.Server#listen does some smart choosing for default host '::' or '0.0.0.0' depending on IPv6 support. Use that instead of binding to localhost specifically. This mimics previous server functionality and allows ngrok access to work again. * chore(deps): updated redux-saga version (react-boilerplate#1388) * Update Changelog.md * Update package.json * 3.4.0 * 3.4.0 * 3.4.0 * docs(toc): include link to new intor document (react-boilerplate#1401) * Update Changelog * chore(deps): update webpack (react-boilerplate#1358) * chore(deps): update webpack * Update 'Introduction' * Cache again * Fix warning during generation of webpack dll file * Describe how to turn off the warnings in production * Bump webpack * Improve the docs * Reorg some templates and add tests (react-boilerplate#1414) * Reorg some templates and add tests - Also make sure that we keep LanguageProvider tests after clean * Move to container structure for internals * Remove old filename ref * Actually remove folders, thanks @Dattaya * Fix react-boilerplate#1300 broken link (react-boilerplate#1429) * Fix react-boilerplate#1435 comment (react-boilerplate#1437) * Add AWS documentation to deployment.md (react-boilerplate#1442) * Add AWS documentation to deployment.md * Minor changes * feature(nginx): integrating mozillas nginx secure tls configuration i… (react-boilerplate#1393) * feature(nginx): integrating mozillas nginx secure tls configuration into .nginx.conf * feature(nginx): updating server-config docs for apache and nginx to reflect security configurations * Update .nginx.conf Add Link for DHE Handshake and minor edits for style/grammar * Update server-configs.md Minor edits for style/grammar * RFC: chore(ci): switch to yarn (react-boilerplate#1415) * chore(ci): switch to yarn * Remove 'yarn version' because: 'Can't answer a question unless a user TTY' * chore(deps): remove chai and chai-enzyme (react-boilerplate#1441) * react-boilerplate#1406 remove lint:css documentation references (react-boilerplate#1445) * Removed redundant lint:css Remove lint:css references * Removed redundant lint:js reference * docs(ISSUE_TEMPLATE): add request for RBP version (react-boilerplate#1425) As there are often several version in various state of completion and we attempt to release often. It's vital to know what version of RBP is involved in issues. * chore(internals): do not check file sizes of main chunk and favicon (react-boilerplate#1424) * chore(internals): do not check file sizes of main chunk and favicon * Reword explanation in the docs * Move test (react-boilerplate#1432) * feature(test): enable build without test Git pre-commit hook still prevents submit failing code * docs(test): updated documentation Clarified test, build and start:production * test(selector test generator): change 'test case' to 'true' This make it easier 'cheat' on the test (double-click to select). Useful when manually testing generator output. * docs(test): updated documentation Clarified start:production * remove erroneous single quote * test(travis): revert yarn calls to npm Travis does not directly support yarn As described at https://blog.travis-ci.com/2016-11-21-travis-ci-now-supports-yarn Travis looks for yarn.lock and maps npm calls to yarn, if present. * config(travis.yaml): move test and build to script section (react-boilerplate#1455) * chore(docs): cleanup of introduction * chore(docs): cleanup of introduction * chore(readme): add hitchhikers guide to the readme * Several minor edits... * Remove (in no particular order) * docs(servers): update server conf files for offline-first per react-boilerplate#645 (react-boilerplate#1381) * docs(servers): update server conf files for offline-first per react-boilerplate#645 re caching see react-boilerplate#645 (comment) Apache http://stackoverflow.com/a/33287352/522756 Nginx https://www.nginx.com/blog/nginx-caching-guide/ * Update .gitattributes added "." to nginx.conf * Remove empty line in list * Picked a nit :-) * chore(core): Move mocks/ folder to internals/ (react-boilerplate#1460) * Update CHANGELOG

@lamoglia

* feat(docs): Extracting packages into their own modules (react-boilerplate#979) * fix(internals): Fix babel relative preset Fix webpack issue with relative babel preset paths: babel/babel-loader#149 * feat(docs): Add docs for extracting components Add draft version of docs describing how to extract components to their own npm packages. * feat(core): Move to Jest for testing (react-boilerplate#980) * Add Jest collect coverage * fix(tests): set config and globals add coverage and script update coveralls script update chai to jest syntax args should return an array chore(tests): add babel-jest, tweak config chore(tests): update coverage settings feat(cov): remove untested closure chore(core): update watch script, use jest-cli fix(watch): add no-cache and watchAll flags * Remove generator test * jest-cli@16 * chore(jest): Remove rootDir * rebase against 3.3.0 * fix(commands): Fix 'npm run clean' breaking (react-boilerplate#1185) (react-boilerplate#1186) Added a constants.js file to templates that contains the DEFAULT_LOCALE export to be added to containers/App/constants on 'npm run clean'. * fix(example): Fix i18n button not updating (react-boilerplate#1187) * feat(docs): Faq: staying updated with boilerplate (react-boilerplate#1192) * fix(example): Fix console error on lang change (react-boilerplate#1200) * fix(core): npm run generate language is not properly created. (react-boilerplate#1199) * rerun extract-intl * add default language to language provider * feat(webpack): new query object syntax (react-boilerplate#1198) * feat(ci): Node v7 support (react-boilerplate#1197) * Node version support update * Update CI node versions * fix(docs): Replace start:prod with independent start:production (react-boilerplate#1204) * fix(example): Fix default Intl polyfill language (react-boilerplate#1208) * fix(docs): Fix typo in file name (react-boilerplate#1211) * fix(example): Use `createStructuredSelector` instead of `createSelector` (react-boilerplate#1212) * chore(deps): update deps roll-up Nov-12-2016 (react-boilerplate#1225) * chore(deps): update deps roll-up Nov-19-2016 (react-boilerplate#1252) * Prevent language duplication (react-boilerplate#1253) * Satisfy ESLint rule: no-restricted-syntax (react-boilerplate#1243) * feat(webpack) Add circular dependency plugin for Webpack. (react-boilerplate#1262) * feat(webpack) Add circular dependency plugin for Webpack. This plugin detects circular dependencies and shows a warning or fails. It is less obtrusive to just show a warning. That's why it defaults to that. * small fix to webpack config * Remove webpack DedupePlugin (react-boilerplate#1218) * Fix typo in container generator (react-boilerplate#1242) * fix(eslint config): resolve numerous invalid lint errors seen in Atom editor (react-boilerplate#1261) * Disable ESLint rule: no-confusing-arrow (react-boilerplate#1238) * Fix links to styled-components doc (react-boilerplate#1289) * Add missing document (Using Sass section CSS) to table content (react-boilerplate#1271) * fix react-boilerplate#1270 * add brackets to document Using Sass * Remove '#if wantCSS' from generator templates (react-boilerplate#1260) Remove '#if wantCSS' from container generator Remove '#if wantCSS' from es6 pure generator template * feat(core): Don't import all of lodash * fix(package.json): Required npm version (react-boilerplate#1219) * Fix wrong npm version introduced with d202b07 Commit d202b07 introduced a not existing npm version of >= 5 which does not exist. The correct npm version is checked during installation which might otherwise lead to an error. Conclusion might be that this was meant to be node >= 5 like mentioned in react-boilerplate#1197 * Add the supported version of node * chore(deps): update deps roll-up Dec-03-2016 (react-boilerplate#1301) * chore(deps): update deps roll-up Dec-03-2016 * fix(deps): sagas loaded twice - roll back react-router-redux 4.0.7 -> 4.0.6 * chore(test config): expand Jest moduleNameMapper key to include common file types (react-boilerplate#1293) * chore(selectors): refactor selectors (react-boilerplate#1205) * Improve .editorconfig, change insert_final_newline to true, add trim_trailing_whitespace (react-boilerplate#1239) * fix(scripts): make LocaleToggle's massages compatible with `extract-intl` script (react-boilerplate#1251) Fixes react-boilerplate#1221 Reverts back react-boilerplate#813 * feat(example): Extracted ReposList (react-boilerplate#1285) * Bfix/reorder imports (react-boilerplate#1275) * Reorder imports * Track package.json * Reorder remaining imports * Revert few changes in app/app.js * Add .ico extension to file-loader regex * Revert favicon, manifest, .htaccess imports * Revert favicon, manifest, .htaccess imports * Remove ico from image-webpack loader extensions * Move offline-plugin import to the top in templates/app.js * Match templates/app.js with app/app.js * Remove import/first from package.json * Reorder webpack alias imports * Reorder imports in internals/generators * Remove German from templates/app.js * fix(templates): use correct name of a selector (react-boilerplate#1321) * chore(generators): clean up generator templates (react-boilerplate#1304) Follow up to react-boilerplate#1260 * fix(generator): react-boilerplate#1231 'generate container' produces unnecessary return (react-boilerplate#1327) * chore(internal): fix indentation in 'routeWithReducer' (react-boilerplate#1329) * fix(HomePage): react-boilerplate#1232 Saga effects should be yielded (react-boilerplate#1328) * fix(generator): 'generate container' produces unnecessary return - better solution (react-boilerplate#1333) * fix(generator): react-boilerplate#1231 'generate container' produces unnecessary return * fix(generator): improved solution to 'generate container' produces unnecessary return react-boilerplate#1327 * feat(ci): allow for linting of the templates (react-boilerplate#1223) * feat(ci): allow for linting of the templates * Add comment at the top describing the purpose of generate-templates-for-linting.js * Use __dirname instead of process.cwd() * Update yarn.lock * Test coverage updates (react-boilerplate#1334) * Exclude test files from test coverage * Add coverage threshold * Update css readme (react-boilerplate#1338) * fix(generators, templates): add example app functionality into project templates and generators (react-boilerplate#1331) * fix(generators, templates): add existing example app functionality into project templates and generators * fix(generators, templates): add existing example app functionality into project templates and generators * split messages import to avoid disabling an eslint rule * feat(server): Add host command line parameter to start (react-boilerplate#1249) * add host parameter to logger * add host parameter to server * update docs to include host command line parameter * update host port command doc based on suggesitons * Rollback image-webpack-loader (react-boilerplate#1342) * Remove babel-jest expicit dependency (react-boilerplate#1345) implements react-boilerplate#1344 * Make compatible with other babel plugins (react-boilerplate#1355) * Remove psi and pagespeed (react-boilerplate#1352) * removing psi, pagespeed, and doc references * remove psi from yarn.lock * Trigger full page reload when hmr fails (react-boilerplate#1357) Fixes react-boilerplate#1353 * refactor(server): remove console.log causing server screen clutter (react-boilerplate#1361) * feat(example): Add route loading progress bar (react-boilerplate#1008) * Add ProgressBar, modify App and write tests * fix eslint warnings * Prevent memory leak in App/index, Fix animation of ProgressBar, Add more tests * Add more tests for ProgressBar life cycle methods * Rename css class names, remove eslint-disable, add comments * Remove comments from ProgressBar tests * Prevent re-rendering of ProgressBar * Fix failing test * Add one more condition to complete progress * Update index.test.js Bring import order in line with react-boilerplate#1275 * Update App/index.js * Update App/index.js * Fix re-rendering and make tests pass * Move progress route hooks out of <App />, update tests * Reset progress bar speed * Move <ProgressBar /> out of <App /> * Update tests * Move withProgressBar to components/ProgressBar * Rename withProgressBar -> index.js. * Add docs for ProgressBar working/usage * Update progress bar.md * Split ProgressBar/styles.js into two separate files * chore(package.json): update dependecy The test/build failed due to a regressed dependency. "react-addons-test-utils": "15.3.2", -> "react-addons-test-utils": "15.4.1", * feat(docs) a beginner's guide to RBP (react-boilerplate#1366) * Create introduction.md * Update introduction.md Minor edits for grammar and structure. Overall, really really good. The hours of dedicated effort you put in will be appreciated by many to come! Very well done 😄 * Update introduction.md Here I have implemented the changes mentioned by @web2style and @lamoglia Thanks guys! :spakles: * Host workflow.png internally * Reference local image in markdown * Rename Workflow.png -> workflow.png * Move to Jest Documentation (react-boilerplate#1390) * Move to Jest Documentation - Move from Mocha to Jest documentation - Remove rewire docs and replace with Jest snapshot information * Minor edits Overall very good, only a few minor edits for style. * Remove jest-cli cmd * Update commands.md * Update deployment.md * fix(core): ngrok not working (react-boilerplate#1399) Node's http.Server#listen does some smart choosing for default host '::' or '0.0.0.0' depending on IPv6 support. Use that instead of binding to localhost specifically. This mimics previous server functionality and allows ngrok access to work again. * chore(deps): updated redux-saga version (react-boilerplate#1388) * Update Changelog.md * Update package.json * 3.4.0 * 3.4.0 * 3.4.0 * docs(toc): include link to new intor document (react-boilerplate#1401) * Update Changelog * chore(deps): update webpack (react-boilerplate#1358) * chore(deps): update webpack * Update 'Introduction' * Cache again * Fix warning during generation of webpack dll file * Describe how to turn off the warnings in production * Bump webpack * Improve the docs * Reorg some templates and add tests (react-boilerplate#1414) * Reorg some templates and add tests - Also make sure that we keep LanguageProvider tests after clean * Move to container structure for internals * Remove old filename ref * Actually remove folders, thanks @Dattaya * Fix react-boilerplate#1300 broken link (react-boilerplate#1429) * Fix react-boilerplate#1435 comment (react-boilerplate#1437) * Add AWS documentation to deployment.md (react-boilerplate#1442) * Add AWS documentation to deployment.md * Minor changes * feature(nginx): integrating mozillas nginx secure tls configuration i… (react-boilerplate#1393) * feature(nginx): integrating mozillas nginx secure tls configuration into .nginx.conf * feature(nginx): updating server-config docs for apache and nginx to reflect security configurations * Update .nginx.conf Add Link for DHE Handshake and minor edits for style/grammar * Update server-configs.md Minor edits for style/grammar * RFC: chore(ci): switch to yarn (react-boilerplate#1415) * chore(ci): switch to yarn * Remove 'yarn version' because: 'Can't answer a question unless a user TTY' * chore(deps): remove chai and chai-enzyme (react-boilerplate#1441) * react-boilerplate#1406 remove lint:css documentation references (react-boilerplate#1445) * Removed redundant lint:css Remove lint:css references * Removed redundant lint:js reference * docs(ISSUE_TEMPLATE): add request for RBP version (react-boilerplate#1425) As there are often several version in various state of completion and we attempt to release often. It's vital to know what version of RBP is involved in issues. * chore(internals): do not check file sizes of main chunk and favicon (react-boilerplate#1424) * chore(internals): do not check file sizes of main chunk and favicon * Reword explanation in the docs * Move test (react-boilerplate#1432) * feature(test): enable build without test Git pre-commit hook still prevents submit failing code * docs(test): updated documentation Clarified test, build and start:production * test(selector test generator): change 'test case' to 'true' This make it easier 'cheat' on the test (double-click to select). Useful when manually testing generator output. * docs(test): updated documentation Clarified start:production * remove erroneous single quote * test(travis): revert yarn calls to npm Travis does not directly support yarn As described at https://blog.travis-ci.com/2016-11-21-travis-ci-now-supports-yarn Travis looks for yarn.lock and maps npm calls to yarn, if present. * config(travis.yaml): move test and build to script section (react-boilerplate#1455) * chore(docs): cleanup of introduction * chore(docs): cleanup of introduction * chore(readme): add hitchhikers guide to the readme * Several minor edits... * Remove (in no particular order) * docs(servers): update server conf files for offline-first per react-boilerplate#645 (react-boilerplate#1381) * docs(servers): update server conf files for offline-first per react-boilerplate#645 re caching see react-boilerplate#645 (comment) Apache http://stackoverflow.com/a/33287352/522756 Nginx https://www.nginx.com/blog/nginx-caching-guide/ * Update .gitattributes added "." to nginx.conf * Remove empty line in list * Picked a nit :-) * chore(core): Move mocks/ folder to internals/ (react-boilerplate#1460) * Update CHANGELOG

lock · 2018-05-29T08:19:54Z

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

mihir0x69 added 4 commits November 27, 2016 15:16

Reorder imports

f648936

Track package.json

7f7f15d

Reorder remaining imports

58b74c0

Revert few changes in app/app.js

f9b9776

Add .ico extension to file-loader regex

d30c171

mihir0x69 added 3 commits November 27, 2016 17:57

Revert favicon, manifest, .htaccess imports

9525c9c

Revert favicon, manifest, .htaccess imports

28f4ca2

Remove ico from image-webpack loader extensions

0c0aa77

Merge dev

9807dda

Merge branch 'dev' into bfix/reorder-imports

e169e20

Merge branch 'dev' into bfix/reorder-imports

b5c6e50

Merge branch 'dev' into bfix/reorder-imports

d41a212

Merge branch 'dev' of https://github.com/mxstbr/react-boilerplate int…

cc98f78

…o dev

Merge dev

821d8b5

Mihir Karandikar added 2 commits December 9, 2016 10:42

Reorder imports in internals/generators

16dc638

Resolve conflicts with dev

5ccd9e5

Dattaya requested changes Dec 9, 2016

View reviewed changes

Remove German from templates/app.js

ffe3dd0

Dattaya approved these changes Dec 9, 2016

View reviewed changes

mxstbr approved these changes Dec 9, 2016

View reviewed changes

gihrig approved these changes Dec 9, 2016

View reviewed changes

gihrig merged commit a09fb22 into react-boilerplate:dev Dec 9, 2016

This was referenced Dec 9, 2016

ESlint style errors after update #1229

Closed

v3.4.0 #1322

Merged

gihrig mentioned this pull request Dec 10, 2016

Feature/route progress bar #1008

Merged

gihrig added a commit to mihir0x69/react-boilerplate that referenced this pull request Dec 10, 2016

Update index.test.js

6289485

Bring import order in line with react-boilerplate#1275

outdooricon mentioned this pull request Dec 30, 2016

Update templates and generators #1400

Closed

lock bot locked as resolved and limited conversation to collaborators May 29, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Bfix/reorder imports #1275

Bfix/reorder imports #1275

mihir0x69 commented Nov 27, 2016

coveralls commented Nov 27, 2016 •

edited

mihir0x69 commented Nov 27, 2016 •

edited

coveralls commented Nov 27, 2016 •

edited

coveralls commented Nov 27, 2016 •

edited

coveralls commented Nov 27, 2016 •

edited

gihrig commented Nov 28, 2016

mihir0x69 commented Nov 28, 2016 •

edited

coveralls commented Nov 28, 2016 •

edited

coveralls commented Nov 28, 2016 •

edited

coveralls commented Dec 1, 2016 •

edited

Dattaya commented Dec 2, 2016

gihrig commented Dec 2, 2016 •

edited

coveralls commented Dec 3, 2016 •

edited

gihrig commented Dec 3, 2016

mihir0x69 commented Dec 3, 2016

gihrig commented Dec 3, 2016

coveralls commented Dec 8, 2016

coveralls commented Dec 8, 2016

mihir0x69 commented Dec 8, 2016

gihrig commented Dec 9, 2016

coveralls commented Dec 9, 2016 •

edited

mihir0x69 commented Dec 9, 2016

gihrig commented Dec 9, 2016

Dattaya left a comment

Dattaya Dec 7, 2016

mxstbr Dec 9, 2016

mihir0x69 Dec 9, 2016

coveralls commented Dec 9, 2016 •

edited

mxstbr left a comment

gihrig commented Dec 9, 2016

mxstbr commented Dec 9, 2016

mihir0x69 commented Dec 11, 2016

lock bot commented May 29, 2018

Bfix/reorder imports #1275

Bfix/reorder imports #1275

Conversation

mihir0x69 commented Nov 27, 2016

coveralls commented Nov 27, 2016 • edited

mihir0x69 commented Nov 27, 2016 • edited

coveralls commented Nov 27, 2016 • edited

coveralls commented Nov 27, 2016 • edited

coveralls commented Nov 27, 2016 • edited

gihrig commented Nov 28, 2016

mihir0x69 commented Nov 28, 2016 • edited

coveralls commented Nov 28, 2016 • edited

coveralls commented Nov 28, 2016 • edited

coveralls commented Dec 1, 2016 • edited

Dattaya commented Dec 2, 2016

gihrig commented Dec 2, 2016 • edited

coveralls commented Dec 3, 2016 • edited

gihrig commented Dec 3, 2016

mihir0x69 commented Dec 3, 2016

gihrig commented Dec 3, 2016

coveralls commented Dec 8, 2016

coveralls commented Dec 8, 2016

mihir0x69 commented Dec 8, 2016

gihrig commented Dec 9, 2016

coveralls commented Dec 9, 2016 • edited

mihir0x69 commented Dec 9, 2016

gihrig commented Dec 9, 2016

Dattaya left a comment

Choose a reason for hiding this comment

Dattaya Dec 7, 2016

Choose a reason for hiding this comment

mxstbr Dec 9, 2016

Choose a reason for hiding this comment

mihir0x69 Dec 9, 2016

Choose a reason for hiding this comment

coveralls commented Dec 9, 2016 • edited

mxstbr left a comment

Choose a reason for hiding this comment

gihrig commented Dec 9, 2016

mxstbr commented Dec 9, 2016

mihir0x69 commented Dec 11, 2016

lock bot commented May 29, 2018

coveralls commented Nov 27, 2016 •

edited

mihir0x69 commented Nov 27, 2016 •

edited

coveralls commented Nov 27, 2016 •

edited

coveralls commented Nov 27, 2016 •

edited

coveralls commented Nov 27, 2016 •

edited

mihir0x69 commented Nov 28, 2016 •

edited

coveralls commented Nov 28, 2016 •

edited

coveralls commented Nov 28, 2016 •

edited

coveralls commented Dec 1, 2016 •

edited

gihrig commented Dec 2, 2016 •

edited

coveralls commented Dec 3, 2016 •

edited

coveralls commented Dec 9, 2016 •

edited

coveralls commented Dec 9, 2016 •

edited