Reorg some templates and add tests #1414

outdooricon · 2017-01-06T19:11:36Z

This adds enough testing to get the post npm run clean code test coverage from this:

to this:

This is important because it sets people on the right track from the start to maintaining high code-coverage. Also, without this the npm build won't be able to run after a clean (that's what triggered my work on it).

gihrig · 2017-01-06T20:44:55Z

I'm getting a test failure on your moreCleanTests branch before cleaning. This is due to #865 which was worked around by disabling ESLint. Now it's become a problem for testing.

It would fantastic if you wanted to fix #865 😄

outdooricon · 2017-01-06T20:50:07Z

Hmm, I'm confused... Why can't I reproduce this error?

gihrig · 2017-01-06T20:58:28Z

After cleaning, all looks good ✨

So, bottom line, this PR looks good to go, but runs into #865 and that breaks the production build.

outdooricon · 2017-01-06T21:01:07Z

ok, addressing #865 right now...

gihrig · 2017-01-06T21:03:58Z

@outdooricon

Hmm, I'm confused... Why can't I reproduce this error?

Good question! What I did.

git clone https://github.com/outdooricon/react-boilerplate.git rbp-tests && rbp-tests
checkout moreCleanTests as local branch (using GitUp)
yarn
npm test

Got that failure.

- Also make sure that we keep LanguageProvider tests after clean

outdooricon · 2017-01-06T21:14:00Z

well that's just bizarre :) Regardless, this should fix it now

coveralls · 2017-01-06T21:16:58Z

Coverage remained the same at 99.245% when pulling 2848268 on outdooricon:moreCleanTests into 503d589 on mxstbr:dev.

gihrig · 2017-01-06T21:57:53Z

OK, all works now 😄

But why place store.test.js in templates/appTests as opposed to templates/appContainer/tests ?

internals/templates/store.test.js → internals/templates/appTests/store.test.js

outdooricon · 2017-01-06T22:02:36Z

Because appContainer is containers/app, whereas appTests correlate to app/. On Fri, Jan 6, 2017, 15:58 Glen Ihrig <notifications@github.com> wrote: OK, all works now 😄 But why place store.test.js in templates/appTests as opposed to templates/appContainer/tests ? internals/templates/store.test.js → internals/templates/*appTests* /store.test.js — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#1414 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAsl4riXL30xdHiMf40Ltpjc0JxbCt58ks5rPrjngaJpZM4LdAu6> .

gihrig · 2017-01-06T22:19:01Z

Because appContainer is containers/app, whereas appTests correlate to app/.

Correction:

Because appContainer is containers/App, whereas appTests correlate to app/.

A naming mess...

I realize this is getting farther away from the original PR, but how about changing templates/appContainer to simply `templates/App'?

That more closely matches the structure of the working application. If there is to be confusion between app and containers/App then it seems to me that app should be renamed to something like client to better match server. But that is way too far beyond the scope of this PR.

outdooricon · 2017-01-06T22:44:02Z

At this point I'd really like to just make a containers folder and then have App and the others inside of it. I feel like that results in the most obvious correlation. What are your thoughts on that?

gihrig · 2017-01-06T22:50:31Z

At this point I'd really like to just make a containers folder and then have App and the others inside of it. I feel like that results in the most obvious correlation. What are your thoughts on that?

Yes, I could go for that!

outdooricon · 2017-01-07T17:49:29Z

Ok @gihrig , done!

coveralls · 2017-01-07T17:53:24Z

Coverage remained the same at 99.245% when pulling c15f1a9 on outdooricon:moreCleanTests into 503d589 on mxstbr:dev.

gihrig

Tested thoroughly as outlined in #1301 all pass! 💯

This is a huge improvement - Thank you @outdooricon 🎉

gihrig · 2017-01-07T21:17:51Z

Oh, almost forgot, bonus points for fixing #863! 🎉

outdooricon · 2017-01-07T22:06:05Z

👍 glad I could help!

coveralls · 2017-01-09T12:22:15Z

Coverage remained the same at 99.245% when pulling f44caa0 on outdooricon:moreCleanTests into 239d8b0 on mxstbr:dev.

outdooricon · 2017-01-09T12:48:37Z

Hmm, this CI error came up after i updated my branch with latest from dev. The source seem to be the change to store.js now running straight "import" for the hot reload in #1358 for node 5 & 6. I'm not really sure what to do at this point, @Dattaya do you have any insight into this?

mxstbr · 2017-01-09T13:41:40Z

Oh wow this is an awesome PR, can we land it for the 3.4 release? I really want to get that out, but this is amazing!

outdooricon · 2017-01-09T14:00:17Z

Thanks! I'd really like that. I just need some guidance on this new CI failure, or maybe someone can kick off CI again with the cache cleared and see if that helps?

Dattaya · 2017-01-09T14:38:51Z

oh, that error reappeared again 😢, it can be solved by either disabling caching of node_modules in .travis.yml (cache: false) or merging #1415.

outdooricon · 2017-01-09T14:45:24Z

Removing the caching seems like a good move, for consistent builds sake, IMO. I'll make the change.

coveralls · 2017-01-09T14:56:42Z

Coverage remained the same at 99.245% when pulling c45adcc on outdooricon:moreCleanTests into 239d8b0 on mxstbr:dev.

outdooricon · 2017-01-09T15:10:27Z

Ok, that's better. @gihrig @Dattaya @mxstbr Are we ok with the no cache solution?

mxstbr · 2017-01-09T15:34:01Z

Are we ok with the no cache solution?

I'm pretty sure this will make build times a lot longer since we have to wait for npm install to finish every single time. Can we somehow invalidate the cache and try again with a fresh install if the build fails?

outdooricon · 2017-01-09T15:47:43Z

@mxstbr I believe so: https://docs.travis-ci.com/user/caching/#Clearing-Caches However, I did not have to permissions to do this. I will back out my travis change if you want to go that route.

Dattaya · 2017-01-09T15:51:57Z

I can't see the cache for this PR, @outdooricon, please, revert back the last commit and I'll clear the cache if the error still persist.

outdooricon · 2017-01-09T16:57:30Z

Ok, I pulled the change. Can someone force travis to start a new build please?

coveralls · 2017-01-09T17:10:52Z

Coverage remained the same at 99.245% when pulling 05fb9c5 on outdooricon:moreCleanTests into 239d8b0 on mxstbr:dev.

outdooricon · 2017-01-09T17:12:15Z

Ok, I just made another minor commit to force the build and it does look like it's still dealing with the cache issue.

Dattaya · 2017-01-09T17:25:27Z

Done—removed the cache, restarted the build and the problem is gone.

Dattaya · 2017-01-09T17:54:54Z

I have one question, not directly related to this PR, because it can be done in another: should we test global-styles.js or just remove it from the coverage report: "!app/global-styles.js",?

Dattaya · 2017-01-09T18:44:55Z

internals/scripts/clean.js

-mkdir('-p', 'app/translations');
-cp('internals/templates/translations/en.json',
-  'app/translations/en.json');
+mv('internals/templates/containers', 'app');


Doesn't work on Windows, but it will work if you remove containers folder completely: rm('-rf', 'app/containers');. Same true for translations.

ah yes, thanks for noticing that

gihrig · 2017-01-09T20:49:31Z

Re caching:

We definitely should have it.
Can we merge RFC: chore(ci): switch to yarn #1415 now? - That should fix the caching issue, and if not we should know about it.

gihrig · 2017-01-09T22:08:38Z

@ Dattaya Re: test global-styles.js, I would say that since it's JS it should be tested, but if it's not practical to get 98%+ coverage for some reason, skip it.

outdooricon · 2017-01-10T02:00:04Z

@ Dattaya Re: test global-styles.js, I would say that since it's JS it should be tested, but if it's not practical to get 98%+ coverage for some reason, skip it.

FWIW, I did take a decent stab at creating a test for it but couldn't for the life of me figure out how to test injectGlobal.

coveralls · 2017-01-10T02:07:18Z

Coverage remained the same at 99.245% when pulling fafe3e6 on outdooricon:moreCleanTests into 239d8b0 on mxstbr:dev.

gihrig · 2017-01-10T03:57:44Z

Tested npm run clean on OS X 10.11.6 all good 💯

Dattaya · 2017-01-10T09:34:08Z

Thank you so much, @outdooricon 💯

@lamoglia

* feat(docs): Extracting packages into their own modules (react-boilerplate#979) * fix(internals): Fix babel relative preset Fix webpack issue with relative babel preset paths: babel/babel-loader#149 * feat(docs): Add docs for extracting components Add draft version of docs describing how to extract components to their own npm packages. * feat(core): Move to Jest for testing (react-boilerplate#980) * Add Jest collect coverage * fix(tests): set config and globals add coverage and script update coveralls script update chai to jest syntax args should return an array chore(tests): add babel-jest, tweak config chore(tests): update coverage settings feat(cov): remove untested closure chore(core): update watch script, use jest-cli fix(watch): add no-cache and watchAll flags * Remove generator test * jest-cli@16 * chore(jest): Remove rootDir * rebase against 3.3.0 * fix(commands): Fix 'npm run clean' breaking (react-boilerplate#1185) (react-boilerplate#1186) Added a constants.js file to templates that contains the DEFAULT_LOCALE export to be added to containers/App/constants on 'npm run clean'. * fix(example): Fix i18n button not updating (react-boilerplate#1187) * feat(docs): Faq: staying updated with boilerplate (react-boilerplate#1192) * fix(example): Fix console error on lang change (react-boilerplate#1200) * fix(core): npm run generate language is not properly created. (react-boilerplate#1199) * rerun extract-intl * add default language to language provider * feat(webpack): new query object syntax (react-boilerplate#1198) * feat(ci): Node v7 support (react-boilerplate#1197) * Node version support update * Update CI node versions * fix(docs): Replace start:prod with independent start:production (react-boilerplate#1204) * fix(example): Fix default Intl polyfill language (react-boilerplate#1208) * fix(docs): Fix typo in file name (react-boilerplate#1211) * fix(example): Use `createStructuredSelector` instead of `createSelector` (react-boilerplate#1212) * chore(deps): update deps roll-up Nov-12-2016 (react-boilerplate#1225) * chore(deps): update deps roll-up Nov-19-2016 (react-boilerplate#1252) * Prevent language duplication (react-boilerplate#1253) * Satisfy ESLint rule: no-restricted-syntax (react-boilerplate#1243) * feat(webpack) Add circular dependency plugin for Webpack. (react-boilerplate#1262) * feat(webpack) Add circular dependency plugin for Webpack. This plugin detects circular dependencies and shows a warning or fails. It is less obtrusive to just show a warning. That's why it defaults to that. * small fix to webpack config * Remove webpack DedupePlugin (react-boilerplate#1218) * Fix typo in container generator (react-boilerplate#1242) * fix(eslint config): resolve numerous invalid lint errors seen in Atom editor (react-boilerplate#1261) * Disable ESLint rule: no-confusing-arrow (react-boilerplate#1238) * Fix links to styled-components doc (react-boilerplate#1289) * Add missing document (Using Sass section CSS) to table content (react-boilerplate#1271) * fix react-boilerplate#1270 * add brackets to document Using Sass * Remove '#if wantCSS' from generator templates (react-boilerplate#1260) Remove '#if wantCSS' from container generator Remove '#if wantCSS' from es6 pure generator template * feat(core): Don't import all of lodash * fix(package.json): Required npm version (react-boilerplate#1219) * Fix wrong npm version introduced with d202b07 Commit d202b07 introduced a not existing npm version of >= 5 which does not exist. The correct npm version is checked during installation which might otherwise lead to an error. Conclusion might be that this was meant to be node >= 5 like mentioned in react-boilerplate#1197 * Add the supported version of node * chore(deps): update deps roll-up Dec-03-2016 (react-boilerplate#1301) * chore(deps): update deps roll-up Dec-03-2016 * fix(deps): sagas loaded twice - roll back react-router-redux 4.0.7 -> 4.0.6 * chore(test config): expand Jest moduleNameMapper key to include common file types (react-boilerplate#1293) * chore(selectors): refactor selectors (react-boilerplate#1205) * Improve .editorconfig, change insert_final_newline to true, add trim_trailing_whitespace (react-boilerplate#1239) * fix(scripts): make LocaleToggle's massages compatible with `extract-intl` script (react-boilerplate#1251) Fixes react-boilerplate#1221 Reverts back react-boilerplate#813 * feat(example): Extracted ReposList (react-boilerplate#1285) * Bfix/reorder imports (react-boilerplate#1275) * Reorder imports * Track package.json * Reorder remaining imports * Revert few changes in app/app.js * Add .ico extension to file-loader regex * Revert favicon, manifest, .htaccess imports * Revert favicon, manifest, .htaccess imports * Remove ico from image-webpack loader extensions * Move offline-plugin import to the top in templates/app.js * Match templates/app.js with app/app.js * Remove import/first from package.json * Reorder webpack alias imports * Reorder imports in internals/generators * Remove German from templates/app.js * fix(templates): use correct name of a selector (react-boilerplate#1321) * chore(generators): clean up generator templates (react-boilerplate#1304) Follow up to react-boilerplate#1260 * fix(generator): react-boilerplate#1231 'generate container' produces unnecessary return (react-boilerplate#1327) * chore(internal): fix indentation in 'routeWithReducer' (react-boilerplate#1329) * fix(HomePage): react-boilerplate#1232 Saga effects should be yielded (react-boilerplate#1328) * fix(generator): 'generate container' produces unnecessary return - better solution (react-boilerplate#1333) * fix(generator): react-boilerplate#1231 'generate container' produces unnecessary return * fix(generator): improved solution to 'generate container' produces unnecessary return react-boilerplate#1327 * feat(ci): allow for linting of the templates (react-boilerplate#1223) * feat(ci): allow for linting of the templates * Add comment at the top describing the purpose of generate-templates-for-linting.js * Use __dirname instead of process.cwd() * Update yarn.lock * Test coverage updates (react-boilerplate#1334) * Exclude test files from test coverage * Add coverage threshold * Update css readme (react-boilerplate#1338) * fix(generators, templates): add example app functionality into project templates and generators (react-boilerplate#1331) * fix(generators, templates): add existing example app functionality into project templates and generators * fix(generators, templates): add existing example app functionality into project templates and generators * split messages import to avoid disabling an eslint rule * feat(server): Add host command line parameter to start (react-boilerplate#1249) * add host parameter to logger * add host parameter to server * update docs to include host command line parameter * update host port command doc based on suggesitons * Rollback image-webpack-loader (react-boilerplate#1342) * Remove babel-jest expicit dependency (react-boilerplate#1345) implements react-boilerplate#1344 * Make compatible with other babel plugins (react-boilerplate#1355) * Remove psi and pagespeed (react-boilerplate#1352) * removing psi, pagespeed, and doc references * remove psi from yarn.lock * Trigger full page reload when hmr fails (react-boilerplate#1357) Fixes react-boilerplate#1353 * refactor(server): remove console.log causing server screen clutter (react-boilerplate#1361) * feat(example): Add route loading progress bar (react-boilerplate#1008) * Add ProgressBar, modify App and write tests * fix eslint warnings * Prevent memory leak in App/index, Fix animation of ProgressBar, Add more tests * Add more tests for ProgressBar life cycle methods * Rename css class names, remove eslint-disable, add comments * Remove comments from ProgressBar tests * Prevent re-rendering of ProgressBar * Fix failing test * Add one more condition to complete progress * Update index.test.js Bring import order in line with react-boilerplate#1275 * Update App/index.js * Update App/index.js * Fix re-rendering and make tests pass * Move progress route hooks out of <App />, update tests * Reset progress bar speed * Move <ProgressBar /> out of <App /> * Update tests * Move withProgressBar to components/ProgressBar * Rename withProgressBar -> index.js. * Add docs for ProgressBar working/usage * Update progress bar.md * Split ProgressBar/styles.js into two separate files * chore(package.json): update dependecy The test/build failed due to a regressed dependency. "react-addons-test-utils": "15.3.2", -> "react-addons-test-utils": "15.4.1", * feat(docs) a beginner's guide to RBP (react-boilerplate#1366) * Create introduction.md * Update introduction.md Minor edits for grammar and structure. Overall, really really good. The hours of dedicated effort you put in will be appreciated by many to come! Very well done 😄 * Update introduction.md Here I have implemented the changes mentioned by @web2style and @lamoglia Thanks guys! :spakles: * Host workflow.png internally * Reference local image in markdown * Rename Workflow.png -> workflow.png * Move to Jest Documentation (react-boilerplate#1390) * Move to Jest Documentation - Move from Mocha to Jest documentation - Remove rewire docs and replace with Jest snapshot information * Minor edits Overall very good, only a few minor edits for style. * Remove jest-cli cmd * Update commands.md * Update deployment.md * fix(core): ngrok not working (react-boilerplate#1399) Node's http.Server#listen does some smart choosing for default host '::' or '0.0.0.0' depending on IPv6 support. Use that instead of binding to localhost specifically. This mimics previous server functionality and allows ngrok access to work again. * chore(deps): updated redux-saga version (react-boilerplate#1388) * Update Changelog.md * Update package.json * 3.4.0 * 3.4.0 * 3.4.0 * docs(toc): include link to new intor document (react-boilerplate#1401) * Update Changelog * chore(deps): update webpack (react-boilerplate#1358) * chore(deps): update webpack * Update 'Introduction' * Cache again * Fix warning during generation of webpack dll file * Describe how to turn off the warnings in production * Bump webpack * Improve the docs * Reorg some templates and add tests (react-boilerplate#1414) * Reorg some templates and add tests - Also make sure that we keep LanguageProvider tests after clean * Move to container structure for internals * Remove old filename ref * Actually remove folders, thanks @Dattaya * Fix react-boilerplate#1300 broken link (react-boilerplate#1429) * Fix react-boilerplate#1435 comment (react-boilerplate#1437) * Add AWS documentation to deployment.md (react-boilerplate#1442) * Add AWS documentation to deployment.md * Minor changes * feature(nginx): integrating mozillas nginx secure tls configuration i… (react-boilerplate#1393) * feature(nginx): integrating mozillas nginx secure tls configuration into .nginx.conf * feature(nginx): updating server-config docs for apache and nginx to reflect security configurations * Update .nginx.conf Add Link for DHE Handshake and minor edits for style/grammar * Update server-configs.md Minor edits for style/grammar * RFC: chore(ci): switch to yarn (react-boilerplate#1415) * chore(ci): switch to yarn * Remove 'yarn version' because: 'Can't answer a question unless a user TTY' * chore(deps): remove chai and chai-enzyme (react-boilerplate#1441) * react-boilerplate#1406 remove lint:css documentation references (react-boilerplate#1445) * Removed redundant lint:css Remove lint:css references * Removed redundant lint:js reference * docs(ISSUE_TEMPLATE): add request for RBP version (react-boilerplate#1425) As there are often several version in various state of completion and we attempt to release often. It's vital to know what version of RBP is involved in issues. * chore(internals): do not check file sizes of main chunk and favicon (react-boilerplate#1424) * chore(internals): do not check file sizes of main chunk and favicon * Reword explanation in the docs * Move test (react-boilerplate#1432) * feature(test): enable build without test Git pre-commit hook still prevents submit failing code * docs(test): updated documentation Clarified test, build and start:production * test(selector test generator): change 'test case' to 'true' This make it easier 'cheat' on the test (double-click to select). Useful when manually testing generator output. * docs(test): updated documentation Clarified start:production * remove erroneous single quote * test(travis): revert yarn calls to npm Travis does not directly support yarn As described at https://blog.travis-ci.com/2016-11-21-travis-ci-now-supports-yarn Travis looks for yarn.lock and maps npm calls to yarn, if present. * config(travis.yaml): move test and build to script section (react-boilerplate#1455) * chore(docs): cleanup of introduction * chore(docs): cleanup of introduction * chore(readme): add hitchhikers guide to the readme * Several minor edits... * Remove (in no particular order) * docs(servers): update server conf files for offline-first per react-boilerplate#645 (react-boilerplate#1381) * docs(servers): update server conf files for offline-first per react-boilerplate#645 re caching see react-boilerplate#645 (comment) Apache http://stackoverflow.com/a/33287352/522756 Nginx https://www.nginx.com/blog/nginx-caching-guide/ * Update .gitattributes added "." to nginx.conf * Remove empty line in list * Picked a nit :-) * chore(core): Move mocks/ folder to internals/ (react-boilerplate#1460) * Update CHANGELOG

@lamoglia

* feat(docs): Extracting packages into their own modules (react-boilerplate#979) * fix(internals): Fix babel relative preset Fix webpack issue with relative babel preset paths: babel/babel-loader#149 * feat(docs): Add docs for extracting components Add draft version of docs describing how to extract components to their own npm packages. * feat(core): Move to Jest for testing (react-boilerplate#980) * Add Jest collect coverage * fix(tests): set config and globals add coverage and script update coveralls script update chai to jest syntax args should return an array chore(tests): add babel-jest, tweak config chore(tests): update coverage settings feat(cov): remove untested closure chore(core): update watch script, use jest-cli fix(watch): add no-cache and watchAll flags * Remove generator test * jest-cli@16 * chore(jest): Remove rootDir * rebase against 3.3.0 * fix(commands): Fix 'npm run clean' breaking (react-boilerplate#1185) (react-boilerplate#1186) Added a constants.js file to templates that contains the DEFAULT_LOCALE export to be added to containers/App/constants on 'npm run clean'. * fix(example): Fix i18n button not updating (react-boilerplate#1187) * feat(docs): Faq: staying updated with boilerplate (react-boilerplate#1192) * fix(example): Fix console error on lang change (react-boilerplate#1200) * fix(core): npm run generate language is not properly created. (react-boilerplate#1199) * rerun extract-intl * add default language to language provider * feat(webpack): new query object syntax (react-boilerplate#1198) * feat(ci): Node v7 support (react-boilerplate#1197) * Node version support update * Update CI node versions * fix(docs): Replace start:prod with independent start:production (react-boilerplate#1204) * fix(example): Fix default Intl polyfill language (react-boilerplate#1208) * fix(docs): Fix typo in file name (react-boilerplate#1211) * fix(example): Use `createStructuredSelector` instead of `createSelector` (react-boilerplate#1212) * chore(deps): update deps roll-up Nov-12-2016 (react-boilerplate#1225) * chore(deps): update deps roll-up Nov-19-2016 (react-boilerplate#1252) * Prevent language duplication (react-boilerplate#1253) * Satisfy ESLint rule: no-restricted-syntax (react-boilerplate#1243) * feat(webpack) Add circular dependency plugin for Webpack. (react-boilerplate#1262) * feat(webpack) Add circular dependency plugin for Webpack. This plugin detects circular dependencies and shows a warning or fails. It is less obtrusive to just show a warning. That's why it defaults to that. * small fix to webpack config * Remove webpack DedupePlugin (react-boilerplate#1218) * Fix typo in container generator (react-boilerplate#1242) * fix(eslint config): resolve numerous invalid lint errors seen in Atom editor (react-boilerplate#1261) * Disable ESLint rule: no-confusing-arrow (react-boilerplate#1238) * Fix links to styled-components doc (react-boilerplate#1289) * Add missing document (Using Sass section CSS) to table content (react-boilerplate#1271) * fix react-boilerplate#1270 * add brackets to document Using Sass * Remove '#if wantCSS' from generator templates (react-boilerplate#1260) Remove '#if wantCSS' from container generator Remove '#if wantCSS' from es6 pure generator template * feat(core): Don't import all of lodash * fix(package.json): Required npm version (react-boilerplate#1219) * Fix wrong npm version introduced with d202b07 Commit d202b07 introduced a not existing npm version of >= 5 which does not exist. The correct npm version is checked during installation which might otherwise lead to an error. Conclusion might be that this was meant to be node >= 5 like mentioned in react-boilerplate#1197 * Add the supported version of node * chore(deps): update deps roll-up Dec-03-2016 (react-boilerplate#1301) * chore(deps): update deps roll-up Dec-03-2016 * fix(deps): sagas loaded twice - roll back react-router-redux 4.0.7 -> 4.0.6 * chore(test config): expand Jest moduleNameMapper key to include common file types (react-boilerplate#1293) * chore(selectors): refactor selectors (react-boilerplate#1205) * Improve .editorconfig, change insert_final_newline to true, add trim_trailing_whitespace (react-boilerplate#1239) * fix(scripts): make LocaleToggle's massages compatible with `extract-intl` script (react-boilerplate#1251) Fixes react-boilerplate#1221 Reverts back react-boilerplate#813 * feat(example): Extracted ReposList (react-boilerplate#1285) * Bfix/reorder imports (react-boilerplate#1275) * Reorder imports * Track package.json * Reorder remaining imports * Revert few changes in app/app.js * Add .ico extension to file-loader regex * Revert favicon, manifest, .htaccess imports * Revert favicon, manifest, .htaccess imports * Remove ico from image-webpack loader extensions * Move offline-plugin import to the top in templates/app.js * Match templates/app.js with app/app.js * Remove import/first from package.json * Reorder webpack alias imports * Reorder imports in internals/generators * Remove German from templates/app.js * fix(templates): use correct name of a selector (react-boilerplate#1321) * chore(generators): clean up generator templates (react-boilerplate#1304) Follow up to react-boilerplate#1260 * fix(generator): react-boilerplate#1231 'generate container' produces unnecessary return (react-boilerplate#1327) * chore(internal): fix indentation in 'routeWithReducer' (react-boilerplate#1329) * fix(HomePage): react-boilerplate#1232 Saga effects should be yielded (react-boilerplate#1328) * fix(generator): 'generate container' produces unnecessary return - better solution (react-boilerplate#1333) * fix(generator): react-boilerplate#1231 'generate container' produces unnecessary return * fix(generator): improved solution to 'generate container' produces unnecessary return react-boilerplate#1327 * feat(ci): allow for linting of the templates (react-boilerplate#1223) * feat(ci): allow for linting of the templates * Add comment at the top describing the purpose of generate-templates-for-linting.js * Use __dirname instead of process.cwd() * Update yarn.lock * Test coverage updates (react-boilerplate#1334) * Exclude test files from test coverage * Add coverage threshold * Update css readme (react-boilerplate#1338) * fix(generators, templates): add example app functionality into project templates and generators (react-boilerplate#1331) * fix(generators, templates): add existing example app functionality into project templates and generators * fix(generators, templates): add existing example app functionality into project templates and generators * split messages import to avoid disabling an eslint rule * feat(server): Add host command line parameter to start (react-boilerplate#1249) * add host parameter to logger * add host parameter to server * update docs to include host command line parameter * update host port command doc based on suggesitons * Rollback image-webpack-loader (react-boilerplate#1342) * Remove babel-jest expicit dependency (react-boilerplate#1345) implements react-boilerplate#1344 * Make compatible with other babel plugins (react-boilerplate#1355) * Remove psi and pagespeed (react-boilerplate#1352) * removing psi, pagespeed, and doc references * remove psi from yarn.lock * Trigger full page reload when hmr fails (react-boilerplate#1357) Fixes react-boilerplate#1353 * refactor(server): remove console.log causing server screen clutter (react-boilerplate#1361) * feat(example): Add route loading progress bar (react-boilerplate#1008) * Add ProgressBar, modify App and write tests * fix eslint warnings * Prevent memory leak in App/index, Fix animation of ProgressBar, Add more tests * Add more tests for ProgressBar life cycle methods * Rename css class names, remove eslint-disable, add comments * Remove comments from ProgressBar tests * Prevent re-rendering of ProgressBar * Fix failing test * Add one more condition to complete progress * Update index.test.js Bring import order in line with react-boilerplate#1275 * Update App/index.js * Update App/index.js * Fix re-rendering and make tests pass * Move progress route hooks out of <App />, update tests * Reset progress bar speed * Move <ProgressBar /> out of <App /> * Update tests * Move withProgressBar to components/ProgressBar * Rename withProgressBar -> index.js. * Add docs for ProgressBar working/usage * Update progress bar.md * Split ProgressBar/styles.js into two separate files * chore(package.json): update dependecy The test/build failed due to a regressed dependency. "react-addons-test-utils": "15.3.2", -> "react-addons-test-utils": "15.4.1", * feat(docs) a beginner's guide to RBP (react-boilerplate#1366) * Create introduction.md * Update introduction.md Minor edits for grammar and structure. Overall, really really good. The hours of dedicated effort you put in will be appreciated by many to come! Very well done 😄 * Update introduction.md Here I have implemented the changes mentioned by @web2style and @lamoglia Thanks guys! :spakles: * Host workflow.png internally * Reference local image in markdown * Rename Workflow.png -> workflow.png * Move to Jest Documentation (react-boilerplate#1390) * Move to Jest Documentation - Move from Mocha to Jest documentation - Remove rewire docs and replace with Jest snapshot information * Minor edits Overall very good, only a few minor edits for style. * Remove jest-cli cmd * Update commands.md * Update deployment.md * fix(core): ngrok not working (react-boilerplate#1399) Node's http.Server#listen does some smart choosing for default host '::' or '0.0.0.0' depending on IPv6 support. Use that instead of binding to localhost specifically. This mimics previous server functionality and allows ngrok access to work again. * chore(deps): updated redux-saga version (react-boilerplate#1388) * Update Changelog.md * Update package.json * 3.4.0 * 3.4.0 * 3.4.0 * docs(toc): include link to new intor document (react-boilerplate#1401) * Update Changelog * chore(deps): update webpack (react-boilerplate#1358) * chore(deps): update webpack * Update 'Introduction' * Cache again * Fix warning during generation of webpack dll file * Describe how to turn off the warnings in production * Bump webpack * Improve the docs * Reorg some templates and add tests (react-boilerplate#1414) * Reorg some templates and add tests - Also make sure that we keep LanguageProvider tests after clean * Move to container structure for internals * Remove old filename ref * Actually remove folders, thanks @Dattaya * Fix react-boilerplate#1300 broken link (react-boilerplate#1429) * Fix react-boilerplate#1435 comment (react-boilerplate#1437) * Add AWS documentation to deployment.md (react-boilerplate#1442) * Add AWS documentation to deployment.md * Minor changes * feature(nginx): integrating mozillas nginx secure tls configuration i… (react-boilerplate#1393) * feature(nginx): integrating mozillas nginx secure tls configuration into .nginx.conf * feature(nginx): updating server-config docs for apache and nginx to reflect security configurations * Update .nginx.conf Add Link for DHE Handshake and minor edits for style/grammar * Update server-configs.md Minor edits for style/grammar * RFC: chore(ci): switch to yarn (react-boilerplate#1415) * chore(ci): switch to yarn * Remove 'yarn version' because: 'Can't answer a question unless a user TTY' * chore(deps): remove chai and chai-enzyme (react-boilerplate#1441) * react-boilerplate#1406 remove lint:css documentation references (react-boilerplate#1445) * Removed redundant lint:css Remove lint:css references * Removed redundant lint:js reference * docs(ISSUE_TEMPLATE): add request for RBP version (react-boilerplate#1425) As there are often several version in various state of completion and we attempt to release often. It's vital to know what version of RBP is involved in issues. * chore(internals): do not check file sizes of main chunk and favicon (react-boilerplate#1424) * chore(internals): do not check file sizes of main chunk and favicon * Reword explanation in the docs * Move test (react-boilerplate#1432) * feature(test): enable build without test Git pre-commit hook still prevents submit failing code * docs(test): updated documentation Clarified test, build and start:production * test(selector test generator): change 'test case' to 'true' This make it easier 'cheat' on the test (double-click to select). Useful when manually testing generator output. * docs(test): updated documentation Clarified start:production * remove erroneous single quote * test(travis): revert yarn calls to npm Travis does not directly support yarn As described at https://blog.travis-ci.com/2016-11-21-travis-ci-now-supports-yarn Travis looks for yarn.lock and maps npm calls to yarn, if present. * config(travis.yaml): move test and build to script section (react-boilerplate#1455) * chore(docs): cleanup of introduction * chore(docs): cleanup of introduction * chore(readme): add hitchhikers guide to the readme * Several minor edits... * Remove (in no particular order) * docs(servers): update server conf files for offline-first per react-boilerplate#645 (react-boilerplate#1381) * docs(servers): update server conf files for offline-first per react-boilerplate#645 re caching see react-boilerplate#645 (comment) Apache http://stackoverflow.com/a/33287352/522756 Nginx https://www.nginx.com/blog/nginx-caching-guide/ * Update .gitattributes added "." to nginx.conf * Remove empty line in list * Picked a nit :-) * chore(core): Move mocks/ folder to internals/ (react-boilerplate#1460) * Update CHANGELOG

lock · 2018-05-29T07:19:50Z

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

Reorg some templates and add tests

2848268

- Also make sure that we keep LanguageProvider tests after clean

outdooricon force-pushed the moreCleanTests branch from 0f43c18 to 2848268 Compare January 6, 2017 21:11

Move to container structure for internals

c15f1a9

gihrig approved these changes Jan 7, 2017

View reviewed changes

gihrig mentioned this pull request Jan 7, 2017

fix(clean): minor errors in cleaned boilerplate #863

Merged

This was referenced Jan 7, 2017

Tests fail in minimal example app after npm run clean #865

Closed

v3.4.0 #1322

Merged

gihrig mentioned this pull request Jan 9, 2017

Include tests (and high coverage) for all components remaining after clean #1410

Closed

2 tasks

Merge branch 'dev' into moreCleanTests

f44caa0

outdooricon force-pushed the moreCleanTests branch from c45adcc to f44caa0 Compare January 9, 2017 16:54

Remove old filename ref

05fb9c5

Dattaya requested changes Jan 9, 2017

View reviewed changes

Actually remove folders, thanks @Dattaya

fafe3e6

Dattaya approved these changes Jan 10, 2017

View reviewed changes

Dattaya merged commit e660697 into react-boilerplate:dev Jan 10, 2017

gihrig mentioned this pull request Jan 10, 2017

Move test #1432

Merged

lock bot locked as resolved and limited conversation to collaborators May 29, 2018

Reorg some templates and add tests #1414

Reorg some templates and add tests #1414

Conversation

outdooricon commented Jan 6, 2017

gihrig commented Jan 6, 2017

outdooricon commented Jan 6, 2017

gihrig commented Jan 6, 2017 • edited

outdooricon commented Jan 6, 2017

gihrig commented Jan 6, 2017

outdooricon commented Jan 6, 2017

coveralls commented Jan 6, 2017 • edited

gihrig commented Jan 6, 2017

outdooricon commented Jan 6, 2017 via email

gihrig commented Jan 6, 2017

outdooricon commented Jan 6, 2017

gihrig commented Jan 6, 2017

outdooricon commented Jan 7, 2017

coveralls commented Jan 7, 2017 • edited

gihrig left a comment

Choose a reason for hiding this comment

gihrig commented Jan 7, 2017

outdooricon commented Jan 7, 2017

coveralls commented Jan 9, 2017

outdooricon commented Jan 9, 2017

mxstbr commented Jan 9, 2017

outdooricon commented Jan 9, 2017

Dattaya commented Jan 9, 2017 • edited

outdooricon commented Jan 9, 2017

coveralls commented Jan 9, 2017 • edited

outdooricon commented Jan 9, 2017

mxstbr commented Jan 9, 2017

outdooricon commented Jan 9, 2017

Dattaya commented Jan 9, 2017

outdooricon commented Jan 9, 2017

coveralls commented Jan 9, 2017 • edited

outdooricon commented Jan 9, 2017

Dattaya commented Jan 9, 2017

Dattaya commented Jan 9, 2017

Dattaya Jan 9, 2017

Choose a reason for hiding this comment

outdooricon Jan 10, 2017

Choose a reason for hiding this comment

gihrig commented Jan 9, 2017

gihrig commented Jan 9, 2017

outdooricon commented Jan 10, 2017

coveralls commented Jan 10, 2017 • edited

gihrig commented Jan 10, 2017

Dattaya commented Jan 10, 2017

lock bot commented May 29, 2018

gihrig commented Jan 6, 2017 •

edited

coveralls commented Jan 6, 2017 •

edited

coveralls commented Jan 7, 2017 •

edited

Dattaya commented Jan 9, 2017 •

edited

coveralls commented Jan 9, 2017 •

edited

coveralls commented Jan 9, 2017 •

edited

coveralls commented Jan 10, 2017 •

edited