Update version #2406
Closed
Update version #2406
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `path` argument of `fs.readFileSync` is relative to the working directory, so linting in Atom was broken for mono-repos (as eslint is not executed from the project root).
Spelling mistake fix in docs
#2290) * [Fix] Fixing issue where apple-touch-icon meta tags are pointing to non-existing sources as they were not generated by Webpack * Adding the 'inject' property to make clear that HTML injection is on
Just a quick update of the docs-- seems IntlProvider was changed to LanguageProvider.
Babel 7 was recently released so I gave a shot at upgrading it. Followed the advice from the official upgrade guide [here](https://babeljs.io/docs/en/v7-migration). Also, stage presets were removed so I used [babel-upgrade](https://github.com/babel/babel-upgrade) to make sure we had the relevant plugins for stage 0 (as we had until now).
…ss's state name (#2325)
#2328) feat(ci): change node versions to use Current and LTS
Return to npm! Updated docs, CI pipelines and setup script as well.
Some docs refer to removing an eslint exception that doesn't exist
👋 I don't think there's an issue for this or that one would be warranted. Happy to open one if that's preferred. The links to VS Code docs were outdated and there was a small typo so fixed it along the way. ## React Boilerplate Thank you for contributing! Please take a moment to review our [**contributing guidelines**](https://github.com/react-boilerplate/react-boilerplate/blob/master/.github/CONTRIBUTING.md) to make the process easy and effective for everyone involved. **Please open an issue** before embarking on any significant pull request, especially those that add a new library or change existing tests, otherwise you risk spending a lot of time working on something that might not end up being merged into the project. Before opening a pull request, please ensure: - [x] You have followed our [**contributing guidelines**](https://github.com/react-boilerplate/react-boilerplate/blob/master/.github/CONTRIBUTING.md) - [x] double-check your branch is based on `dev` and targets `dev` - [x] Pull request has tests (we are going for 100% coverage!) - [x] Code is well-commented, linted and follows project conventions - [x] Documentation is updated (if necessary) - [x] Internal code generators and templates are updated (if necessary) - [x] Description explains the issue/use-case resolved and auto-closes related issues Be kind to code reviewers, please try to keep pull requests as small and focused as possible :) **IMPORTANT**: By submitting a patch, you agree to allow the project owners to license your work under the terms of the [MIT License](https://github.com/react-boilerplate/react-boilerplate/blob/master/LICENSE.md).
npm start does not start ngrok tunnel. PR to update docs accordingly ## React Boilerplate Thank you for contributing! Please take a moment to review our [**contributing guidelines**](https://github.com/react-boilerplate/react-boilerplate/blob/master/.github/CONTRIBUTING.md) to make the process easy and effective for everyone involved. **Please open an issue** before embarking on any significant pull request, especially those that add a new library or change existing tests, otherwise you risk spending a lot of time working on something that might not end up being merged into the project. Before opening a pull request, please ensure: - [x] You have followed our [**contributing guidelines**](https://github.com/react-boilerplate/react-boilerplate/blob/master/.github/CONTRIBUTING.md) - [x] double-check your branch is based on `dev` and targets `dev` - [ ] Pull request has tests (we are going for 100% coverage!) - [ ] Code is well-commented, linted and follows project conventions - [x] Documentation is updated (if necessary) - [ ] Internal code generators and templates are updated (if necessary) - [x] Description explains the issue/use-case resolved and auto-closes related issues Be kind to code reviewers, please try to keep pull requests as small and focused as possible :) **IMPORTANT**: By submitting a patch, you agree to allow the project owners to license your work under the terms of the [MIT License](https://github.com/react-boilerplate/react-boilerplate/blob/master/LICENSE.md).
… to help the babel 6 => 7 transition
- Fixes - Linting/prettier - Dependency upgrades - Switch Appveyor to `npm ci` - More incoming
* Fix VS Code debugging instructions + spelling/grammar * Moar spelling * Capitalz * Created a section for RBP forks to clean up the electron stuff and add gretzky's SSR repo
TypeScript fork added to forks readme. #2351
* Migrated from react-router-redux to connected-react-router * Readability and protection for createReducer function * Switch to default param in createReducer * Documentation update for switch to connected-react-router
This makes it so that you get a nicely named project out of the box.
- Generated saga has a meaningful name rather than `defaultSaga`. - Since `saga.js` has a default export, we should also use a default import in `saga.test.js` file.
Upgrade to `styled-components` v4 is fully tested and working. Minor doc updates included. Tests are now using enzyme's `mount` and styled-components's `enzymeFind` util (perhaps a good argument for switching to `react-testing-library` per @Mensae's advice?). Also, CSS linting had to be temporarily removed from CI suites as `stylelint` is giving an "Unknown word" error in `Circle.js`. (On a portion of the code that wasn't changed by the upgrade.) Will keep an eye on this and restore when possible.
Rather than a huge ambitious webpack overhaul, I tackled just 1 big piece and 1 small: the DLL plugin and polyfills. **DLL** I've completely removed the DLL setup we had going and replaced it with `webpack.optimization` and `compression-webpack-plugin`. I've set optimizations for splitting chunks in prod to handle vendor cache groups, which is pretty snappy in development. I've also setup `uglifyjs-webpack-plugin` to enable caching and multi-process parallel running at the same time (this is handled in optimization as well). Along with this, I've added compression plugin to build gzipped bundles. These are served by express and the bundles are cut down by half or more. **Polyfill** I've added [`react-app-polyfill`](https://github.com/facebook/create-react-app/blob/master/packages/react-app-polyfill) that has common polyfills for the browser and supports up to IE11.
* switched to terser-webpack-plugin from uglifyjs-webpack-plugin * restored comparisons: false to terser config
|
Woah nvm, mine is gassed out |
|
Good try ;) |
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updating the
package.jsonto reflect the version change 🤐