Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Implement custom filter logic" demo is buggy #1007

Closed
nickhellings opened this issue Jul 12, 2019 · 6 comments
Closed

"Implement custom filter logic" demo is buggy #1007

nickhellings opened this issue Jul 12, 2019 · 6 comments

Comments

@nickhellings
Copy link

It looks like this is related to this issue: #682

Basically the demo case found here is not correct.

I created a gif of the problem:
react bootstrap table 2 issue As you can see the product price filter which overrides the onFilter function has some issues when using multiple columns to filter.

As I read in the other thread apparently I could use the exposed api to implement this behavior properly, so at least that hopefully solves my issue, but I thought I should inform you about this bug in the demo.

Good work on the library by the way! I love it.

Have a nice day.

@AllenFang
Copy link
Member

@nickhellings sorry for lately reply, I will check this out, thanks your finding!!

@AllenFang AllenFang added this to To do in release-2019-q2-6 via automation Jul 21, 2019
@AllenFang
Copy link
Member

I think this is a example bug, I will fix it soon, thank you

release-2019-q2-6 automation moved this from To do to Done Jul 22, 2019
@AllenFang
Copy link
Member

@nickhellings fixed in newest version

@nickhellings
Copy link
Author

@AllenFang Has this been released? As far as I can see in custom filter example this is still not working as intended. I think this is not just a bug in the example. It is a bug in the underlying code.

The use case as shown in my GIF in the original post is still not working.

Thanks!

@AllenFang
Copy link
Member

@nickhellings sorry for my roughy bug checking, there's a bug actually, i will fix it soon, thanks

@AllenFang AllenFang reopened this Jul 27, 2019
release-2019-q2-6 automation moved this from Done to In progress Jul 27, 2019
@AllenFang AllenFang added this to To do in release-2019-q2-7 via automation Jul 27, 2019
AllenFang added a commit that referenced this issue Jul 27, 2019
@AllenFang AllenFang mentioned this issue Jul 27, 2019
release-2019-q2-6 automation moved this from In progress to Done Aug 12, 2019
release-2019-q2-7 automation moved this from To do to Done Aug 12, 2019
@AllenFang
Copy link
Member

@nickhellings I fixed in newest version, please upgrade to newest version, thanks
here is release note

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Development

No branches or pull requests

2 participants