-
Notifications
You must be signed in to change notification settings - Fork 432
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
"Implement custom filter logic" demo is buggy #1007
Comments
@nickhellings sorry for lately reply, I will check this out, thanks your finding!! |
I think this is a example bug, I will fix it soon, thank you |
@nickhellings fixed in newest version |
@AllenFang Has this been released? As far as I can see in custom filter example this is still not working as intended. I think this is not just a bug in the example. It is a bug in the underlying code. The use case as shown in my GIF in the original post is still not working. Thanks! |
@nickhellings sorry for my roughy bug checking, there's a bug actually, i will fix it soon, thanks |
@nickhellings I fixed in newest version, please upgrade to newest version, thanks |
It looks like this is related to this issue: #682
Basically the demo case found here is not correct.
I created a gif of the problem:
As you can see the product price filter which overrides the onFilter function has some issues when using multiple columns to filter.
As I read in the other thread apparently I could use the exposed api to implement this behavior properly, so at least that hopefully solves my issue, but I thought I should inform you about this bug in the demo.
Good work on the library by the way! I love it.
Have a nice day.
The text was updated successfully, but these errors were encountered: