[iOS] Fixed issue that app will crash after trigger Marker onDragEnd #2501
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@guoliang1206 thank you ❤️ LGTM @alvelig 🐽 |
MarcoChenBB
pushed a commit
to MarcoChenBB/react-native-maps
that referenced
this pull request
Jan 30, 2019
This PR is fixing an issue of crashing after dragging a map marker. It is replicating the changes of the PR in the following link. react-native-maps#2501
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Does any other open PR do the same thing?
No
What issue is this PR fixing?
When drag the Marker on map, sometimes app will crash when onDragEnd.
How did you test this PR?
Tested on iOS simulator with iOS11.4, iOS 12.0
iPhone6 12.0